Re: [HACKERS] ATSimpleRecursion() and inheritance foreign parents

2015-04-30 Thread Etsuro Fujita
On 2015/04/29 4:35, Tom Lane wrote: Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: On 2015/04/28 15:17, Amit Langote wrote: The code at the beginning of ATSimpleRecursion() looks like - if (recurse rel-rd_rel-relkind == RELKIND_RELATION) Not sure if it's great idea, but now that foreign

Re: [HACKERS] ATSimpleRecursion() and inheritance foreign parents

2015-04-28 Thread Etsuro Fujita
On 2015/04/28 15:17, Amit Langote wrote: The code at the beginning of ATSimpleRecursion() looks like - /* * Propagate to children if desired. Non-table relations never have * children, so no need to search in that case. */ if (recurse rel-rd_rel-relkind == RELKIND_RELATION) Not sure

[HACKERS] ATSimpleRecursion() and inheritance foreign parents

2015-04-28 Thread Amit Langote
Hi, Following ALTER TABLE actions are applied recursively to inheritance descendents via ATSimpleRecursion() - ALTER COLUMN DEFAULT ALTER COLUMN DROP NOT NULL ALTER COLUMN SET NOT NULL ALTER COLUMN SET STATISTICS ALTER COLUMN SET STORAGE The code at the beginning of ATSimpleRecursion() looks

Re: [HACKERS] ATSimpleRecursion() and inheritance foreign parents

2015-04-28 Thread Tom Lane
Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: On 2015/04/28 15:17, Amit Langote wrote: The code at the beginning of ATSimpleRecursion() looks like - if (recurse rel-rd_rel-relkind == RELKIND_RELATION) Not sure if it's great idea, but now that foreign tables can also have children, should