On Thu, Jul 23, 2015 at 9:55 AM, Fabrízio de Royes Mello wrote:
Thank you for the review.
+ /* skipp if the name already exists and if_not_exists is true */
s/skipp/skip.
Except that this looks in good shape to me (see attached for a version
fixing the typo) so switched to Ready for
On Thu, Jul 16, 2015 at 10:36 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
I had a look at this patch, and here are some minor comments:
1) In alter_table.sgml, you need a space here:
[ IF NOT EXISTS ]replaceable
Fixed.
2)
+ check_for_column_name_collision(targetrelation,
On Fri, Jun 26, 2015 at 12:41 AM, Fabrízio de Royes Mello
fabriziome...@gmail.com wrote:
On Wed, Jun 24, 2015 at 3:36 PM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
Fabrízio de Royes Mello wrote:
Another rebased version.
There are a number of unrelated whitespace changes in this
On Wed, Jun 24, 2015 at 3:36 PM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
Fabrízio de Royes Mello wrote:
Another rebased version.
There are a number of unrelated whitespace changes in this patch; also
please update the comment on top of check_for_column_name_collision.
Sorry, bad
Fabrízio de Royes Mello wrote:
Another rebased version.
There are a number of unrelated whitespace changes in this patch; also
please update the comment on top of check_for_column_name_collision.
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
On Thu, Apr 23, 2015 at 12:05 PM, Fabrízio de Royes Mello
fabriziome...@gmail.com wrote:
On Wed, Apr 22, 2015 at 3:48 PM, Payal Singh pa...@omniti.com wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements
On Wed, Apr 22, 2015 at 3:48 PM, Payal Singh pa...@omniti.com wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Seeing this when trying to apply the patch:
Patching file
Hi all,
This simple patch add CINE for ALTER TABLE ... ADD COLUMN.
So now we can:
ALTER TABLE foo
ADD COLUMN IF NOT EXISTS c1 integer;
and/or ...
ALTER TABLE foo
ADD COLUMN IF NOT EXISTS c1 integer,
ADD COLUMN c2 integer;
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching
