Re: [HACKERS] Add regression tests for SET xxx

2013-07-15 Thread Robert Haas
On Sun, Jul 7, 2013 at 1:15 PM, Robins Tharakan thara...@gmail.com wrote: Updated the patch: - Updated ROLE names as per Robert's feedback (regress_xxx) - Added test to serial_schedule Please see my comments on the LOCK tests related to these points and update accordingly. +BEGIN TRANSACTION;

Re: [HACKERS] Add regression tests for SET xxx

2013-07-07 Thread Robins Tharakan
On 18 June 2013 05:01, Szymon Guz mabew...@gmail.com wrote: I've checked the patch. Applies cleanly. Tests pass this time :) Updated the patch: - Updated ROLE names as per Robert's feedback (regress_xxx) - Added test to serial_schedule -- Robins Tharakan regress_variable_v5.patch

Re: [HACKERS] Add regression tests for SET xxx

2013-06-18 Thread Szymon Guz
On 18 June 2013 02:33, Robins Tharakan thara...@gmail.com wrote: Thanks ! PFA the updated patch. Also remove a trailing whitespace at the end of SQL script. -- Robins Tharakan On 17 June 2013 17:29, Szymon Guz mabew...@gmail.com wrote: On 26 May 2013 19:56, Robins Tharakan

Re: [HACKERS] Add regression tests for SET xxx

2013-06-18 Thread Michael Paquier
On Tue, Jun 18, 2013 at 7:01 PM, Szymon Guz mabew...@gmail.com wrote: Could you add me as a reviewer to commitfest website, set this patch a reviewed and add this email to the patch history? I cannot login to the commitfest app, there is some bug with that. You should be able to do it yourself

Re: [HACKERS] Add regression tests for SET xxx

2013-06-18 Thread Szymon Guz
On 18 June 2013 13:10, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Jun 18, 2013 at 7:01 PM, Szymon Guz mabew...@gmail.com wrote: Could you add me as a reviewer to commitfest website, set this patch a reviewed and add this email to the patch history? I cannot login to the

Re: [HACKERS] Add regression tests for SET xxx

2013-06-18 Thread Szymon Guz
On 18 June 2013 17:29, Kevin Grittner kgri...@ymail.com wrote: Szymon Guz mabew...@gmail.com wrote: I've checked the patch. Applies cleanly. Tests pass this time :) Could you add me as a reviewer to commitfest website, set this patch a reviewed and add this email to the patch history?

Re: [HACKERS] Add regression tests for SET xxx

2013-06-18 Thread Kevin Grittner
Szymon Guz mabew...@gmail.com wrote: I've checked the patch. Applies cleanly. Tests pass this time :) Could you add me as a reviewer to commitfest website, set this patch a reviewed and add this email to the patch history? I cannot login to the commitfest app, there is some bug with that.

Re: [HACKERS] Add regression tests for SET xxx

2013-06-17 Thread Szymon Guz
On 26 May 2013 19:56, Robins Tharakan thara...@gmail.com wrote: Hi, Please find attached a patch to take code-coverage of SET (SESSION / SEED / TRANSACTION / DATESTYLE / TIME ZONE) (src/backend/commands/variable.c) from 65% to 82%. Any and all feedback is welcome. -- Robins Tharakan

Re: [HACKERS] Add regression tests for SET xxx

2013-06-17 Thread Robins Tharakan
Thanks ! PFA the updated patch. Also remove a trailing whitespace at the end of SQL script. -- Robins Tharakan On 17 June 2013 17:29, Szymon Guz mabew...@gmail.com wrote: On 26 May 2013 19:56, Robins Tharakan thara...@gmail.com wrote: Hi, Please find attached a patch to take

[HACKERS] Add regression tests for SET xxx

2013-05-26 Thread Robins Tharakan
Hi, Please find attached a patch to take code-coverage of SET (SESSION / SEED / TRANSACTION / DATESTYLE / TIME ZONE) (src/backend/commands/variable.c) from 65% to 82%. Any and all feedback is welcome. -- Robins Tharakan regress_variable.patch Description: Binary data -- Sent via