Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-08-21 Thread Andres Freund
On 2014-07-02 08:55:05 +, Rajeev rastogi wrote: Also can we change the description of function pg_buffercache_pages to include pinning_backend also in the description. I'm not sure what you mean here - I've adjusted the docs to include the column? Or do you mean that it errorneously was

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-07-02 Thread Rajeev rastogi
On 23 June 2014 15:22, Andres Freund Wrote: This may be harmless but pinning_backends should be defined as int4 rather than int8 because BufferDesc-refcount is just defined as unsigned and it's converted to Datum by Int32GetDatum(). Well, in theory a uint32 can't generally be converted

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Fujii Masao
On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers pinned. Once during development and once while analyzing a stuck vacuum (waiting for a cleanup lock). I'd like to add a column to

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Andres Freund
On 2014-06-23 18:44:24 +0900, Fujii Masao wrote: On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers pinned. Once during development and once while analyzing a stuck vacuum (waiting

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 6:51 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-06-23 18:44:24 +0900, Fujii Masao wrote: On Sat, Apr 12, 2014 at 9:25 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, The last week I twice had the need to see how many backends had some buffers

[HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-04-12 Thread Andres Freund
Hi, The last week I twice had the need to see how many backends had some buffers pinned. Once during development and once while analyzing a stuck vacuum (waiting for a cleanup lock). I'd like to add a column to pg_buffercache exposing that. The name I've come up with is 'pinning_backends' to