Re: [HACKERS] Assert in pg_stat_statements

2015-08-09 Thread Satoshi Nagayasu
2015-08-10 2:23 GMT+09:00 Tom Lane : > Robert Haas writes: >> I'm not too excited about supporting the use case where there are two >> people using queryId but it just so happens that they always set >> exactly the same value. That seems like a weird setup. Wouldn't that >> mean both modules wer

Re: [HACKERS] Assert in pg_stat_statements

2015-08-09 Thread Satoshi Nagayasu
2015-08-10 0:04 GMT+09:00 Robert Haas : > On Sun, Aug 9, 2015 at 1:36 AM, Satoshi Nagayasu wrote: >> On 2015/08/08 22:32, Robert Haas wrote: >>> On Sat, Aug 8, 2015 at 5:00 AM, Satoshi Nagayasu wrote: I just found that pg_stat_statements causes assert when queryId is set by other m

Re: [HACKERS] Assert in pg_stat_statements

2015-08-09 Thread Peter Geoghegan
On Sun, Aug 9, 2015 at 10:23 AM, Tom Lane wrote: > If there's actually a use case for that sort of thing, I would vote > for moving the jumble-calculation code into core I think that there'd be a good case for doing that for several other reasons. It would be great to have a per-queryId log_min_d

Re: [HACKERS] Assert in pg_stat_statements

2015-08-09 Thread Tom Lane
Robert Haas writes: > I'm not too excited about supporting the use case where there are two > people using queryId but it just so happens that they always set > exactly the same value. That seems like a weird setup. Wouldn't that > mean both modules were applying the same jumble algorithm, and >

Re: [HACKERS] Assert in pg_stat_statements

2015-08-09 Thread Robert Haas
On Sun, Aug 9, 2015 at 1:36 AM, Satoshi Nagayasu wrote: > On 2015/08/08 22:32, Robert Haas wrote: >> On Sat, Aug 8, 2015 at 5:00 AM, Satoshi Nagayasu wrote: >>> >>> I just found that pg_stat_statements causes assert when queryId is >>> set by other module, which is loaded prior to pg_stat_stateme

Re: [HACKERS] Assert in pg_stat_statements

2015-08-08 Thread Satoshi Nagayasu
On 2015/08/08 22:32, Robert Haas wrote: On Sat, Aug 8, 2015 at 5:00 AM, Satoshi Nagayasu wrote: I just found that pg_stat_statements causes assert when queryId is set by other module, which is loaded prior to pg_stat_statements in the shared_preload_libraries parameter. Theoretically, queryId

[HACKERS] Assert in pg_stat_statements

2015-08-08 Thread Satoshi Nagayasu
Hi, I just found that pg_stat_statements causes assert when queryId is set by other module, which is loaded prior to pg_stat_statements in the shared_preload_libraries parameter. Theoretically, queryId in the shared memory could be set by other module by design. So, IMHO, pg_stat_statements shou