Re: Bitmap Indexes patch (was Re: [HACKERS] Bitmap Indexes: request for feedback)

2008-11-04 Thread Gianni Ciolli
On Mon, Nov 03, 2008 at 04:53:28PM -0700, Vladimir Sitnikov wrote: > I wish to focus on the performance aspect of the patch, however, it turned > out there are major issues with functionality: the index stores wrong tids > inside :( > I really would love to fix that issue and have a chance to valid

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Simon Riggs
On Wed, 2008-10-22 at 10:00 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I agree we could do the stream bitmap as well, but I'd suggest we should > > save that until the rest of the patch has been checked out. > > Well, that would be a reasonable implementation path, but i

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I agree we could do the stream bitmap as well, but I'd suggest we should > save that until the rest of the patch has been checked out. Well, that would be a reasonable implementation path, but it's got nothing to do with the patch as presented. The concer

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Simon Riggs
On Wed, 2008-10-22 at 09:13 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Wed, 2008-10-22 at 08:31 -0400, Tom Lane wrote: > >> No, that was merely one component of the problem. The APIs for > >> tidbitmaps need revision too. You can't "stream" a bitmap yet. > > > Pleas

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Wed, 2008-10-22 at 08:31 -0400, Tom Lane wrote: >> No, that was merely one component of the problem. The APIs for >> tidbitmaps need revision too. You can't "stream" a bitmap yet. > Please explain further. > Which calls? Why do we need to stream them?

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Simon Riggs
On Wed, 2008-10-22 at 08:31 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Wed, 2008-10-22 at 00:00 +0100, Gregory Stark wrote: > >> When we last left our heros they were proposing ways to refactor the index > >> api > >> to allow index ams to stream results to the execut

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Wed, 2008-10-22 at 00:00 +0100, Gregory Stark wrote: >> When we last left our heros they were proposing ways to refactor the index >> api >> to allow index ams to stream results to the executor in bitmap form. > The indexAM API has now been changed, so

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Mark Kirkwood
Josh Berkus wrote: The other major issue with the Bitmap index patch as it stood in 2007 was that performance just wasn't that much faster than a btree, except for specific corner cases. Otherwise, someone else would have been interested enough to pick it up and finish it. So performance

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Simon Riggs
On Tue, 2008-10-21 at 14:26 -0700, Josh Berkus wrote: > Gianni, > > > me and Gabriele Bartolini have been working on Bitmap Indexes (BMI) in > > the last weeks, with advice and guidance from Simon Riggs. We feel > > that we are about to approach the point where it is appropriate to ask > > for fe

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-22 Thread Simon Riggs
On Wed, 2008-10-22 at 00:00 +0100, Gregory Stark wrote: > Actually as I recall the immediate issue was that the patch was more complex > than necessary. In particular it reimplemented parts of the executor > internally rather than figuring out what api was necessary to integrate it > fully into t

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-21 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Josh Berkus <[EMAIL PROTECTED]> writes: >> The other major issue with the Bitmap index patch as it stood in 2007 was >> that performance just wasn't that much faster than a btree, except for >> specific corner cases. Otherwise, someone else would have

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-21 Thread Gregory Stark
Josh Berkus <[EMAIL PROTECTED]> writes: > Gianni, > >> me and Gabriele Bartolini have been working on Bitmap Indexes (BMI) in >> the last weeks, with advice and guidance from Simon Riggs. We feel >> that we are about to approach the point where it is appropriate to ask >> for feedback from this li

Re: [HACKERS] Bitmap Indexes: request for feedback

2008-10-21 Thread Josh Berkus
Gianni, > me and Gabriele Bartolini have been working on Bitmap Indexes (BMI) in > the last weeks, with advice and guidance from Simon Riggs. We feel > that we are about to approach the point where it is appropriate to ask > for feedback from this list. The other major issue with the Bitmap index

[HACKERS] Bitmap Indexes: request for feedback

2008-10-21 Thread Gianni Ciolli
Hi everybody, me and Gabriele Bartolini have been working on Bitmap Indexes (BMI) in the last weeks, with advice and guidance from Simon Riggs. We feel that we are about to approach the point where it is appropriate to ask for feedback from this list. Thank you, Dr. Gianni Ciolli - 2ndQuadrant It