Re: [HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-06-01 Thread Tom Lane
I wrote: > "Kurt Harriman" <[EMAIL PROTECTED]> writes: >> Just noticed buffile.c:292 doesn't look quite right where >> BufFileDumpBuffer calls FileWrite: >> bytestowrite = FileWrite(thisfile, file->buffer, bytestowrite); >> It looks as though it would write the same data each time the >> loop is it

Re: [HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-05-17 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > This has been saved for the 8.4 release: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > Huh, no, this is a bug and should be fixed right away. OK, moved to the 8.3 patch queue. --

Re: [HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-05-16 Thread Alvaro Herrera
Bruce Momjian wrote: > > This has been saved for the 8.4 release: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold Huh, no, this is a bug and should be fixed right away. > --- > > Tom Lane wrote: > > "Kurt Ha

Re: [HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-05-16 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Tom Lane wrote: > "Kurt Harriman" <[EMAIL PROTECTED]> writes: > > Just noticed buffile.c:292 doesn't look quite right

Re: [HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-05-07 Thread Tom Lane
"Kurt Harriman" <[EMAIL PROTECTED]> writes: > Just noticed buffile.c:292 doesn't look quite right where > BufFileDumpBuffer calls FileWrite: > bytestowrite = FileWrite(thisfile, file->buffer, bytestowrite); > It looks as though it would write the same data each time the > loop is iterated. Wo

[HACKERS] BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

2007-05-07 Thread Kurt Harriman
Just noticed buffile.c:292 doesn't look quite right where BufFileDumpBuffer calls FileWrite: bytestowrite = FileWrite(thisfile, file->buffer, bytestowrite); It looks as though it would write the same data each time the loop is iterated. Would this be better? bytestowrite = FileWrite(thisf