Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

Thanks for the objection with clear reasoning. For clarity, I first proposed to prohibit servers of different versions from sharing same tablespace directory. https://www.postgresql.org/message-id/20170406.160844.120459562.horiguchi.kyot...@lab.ntt.co.jp And I had -1 that it is just a reverting

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On 30/09/17 06:43, Robert Haas wrote: On Fri, Sep 29, 2017 at 2:06 AM, Michael Paquier wrote: My tendency about this patch is still that it should be rejected. This is presenting additional handling for no real gain. I vehemently disagree. If the server lets you

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Fri, Sep 29, 2017 at 2:06 AM, Michael Paquier wrote: > My tendency about this patch is still that it should be rejected. This > is presenting additional handling for no real gain. I vehemently disagree. If the server lets you create a tablespace, then everything

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Fri, Sep 29, 2017 at 2:19 PM, Kyotaro HORIGUCHI wrote: > It would practically work but I don't like the fact that the > patch relies on the specific directory/file ordering in the tar > stream. This is not about the CATVER directory but lower > directories.

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

Hi, At Tue, 19 Sep 2017 17:07:10 +0200, Pierre Ducroquet wrote in <1678633.OBaBNztJnJ@pierred-pdoc> > On Tuesday, September 19, 2017 12:52:37 PM CEST you wrote: > > On Thu, Sep 14, 2017 at 2:17 AM, Pierre Ducroquet > wrote: > > > All my

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

El 13/09/17 a las 14:17, Pierre Ducroquet escribió: > + boolfirstfile = 1; You are still assigning 1 to a bool (which is not incorrect) instead of true or false as Michael mentioned before. P.D.: I didn't go though all the thread and patch in depth so will not comment further.

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Tuesday, September 19, 2017 12:52:37 PM CEST you wrote: > On Thu, Sep 14, 2017 at 2:17 AM, Pierre Ducroquet wrote: > > All my apologies for the schockingly long time with no answer on this > > topic. > No problem. That's the concept called life I suppose. > > > I will do

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Thu, Sep 14, 2017 at 2:17 AM, Pierre Ducroquet wrote: > All my apologies for the schockingly long time with no answer on this topic. No problem. That's the concept called life I suppose. > I will do my best to help review some patches in the current CF. Thanks for the

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Wednesday, September 13, 2017 6:01:43 PM CEST you wrote: > > On 15 May 2017, at 07:26, Michael Paquier > > wrote:> > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > > > I

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

> On 15 May 2017, at 07:26, Michael Paquier wrote: > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > I have not spotted any flaws in the refactored logic. This patch no

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > I didn't have much time to spend on that issue until today, and I found a > way to solve it that seems acceptable to me. > > The biggest drawback will be that if the backup is interrupted, previous > tablespaces

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

Hi, I noticed this just now. At Mon, 01 May 2017 19:28:59 +0200, Pierre Ducroquet wrote in <05c62730-8670-4da6-b783-52e66fb42...@pinaraf.info> > I didn't have much time to spend on that issue until today, and I > found a way to solve it that seems acceptable to me. > > The

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Friday, April 7, 2017 3:12:58 AM CEST, Kyotaro HORIGUCHI wrote: Hi, Pierre. Maybe you're the winner:p At Thu, 06 Apr 2017 12:34:09 +0200, Pierre Ducroquet wrote in <1714428.BHRm6e8A2D@peanuts2> On Thursday, April 6, 2017 2:00:55 PM CEST Kyotaro HORIGUCHI wrote: ...

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

Hi, Pierre. Maybe you're the winner:p At Thu, 06 Apr 2017 12:34:09 +0200, Pierre Ducroquet wrote in <1714428.BHRm6e8A2D@peanuts2> > On Thursday, April 6, 2017 2:00:55 PM CEST Kyotaro HORIGUCHI wrote: > > https://www.postgresql.org/docs/9.6/static/manage-ag-tablespaces.html

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

On Thursday, April 6, 2017 2:00:55 PM CEST Kyotaro HORIGUCHI wrote: > At Thu, 06 Apr 2017 00:59:49 +0200, Pierre Ducroquet > wrote in <2008148.rxBNyNRHPZ@peanuts2> > > But it all gets messy when we want to create a streaming standby server > > using pg_basebackup. When

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

At Thu, 06 Apr 2017 00:59:49 +0200, Pierre Ducroquet wrote in <2008148.rxBNyNRHPZ@peanuts2> > But it all gets messy when we want to create a streaming standby server using > pg_basebackup. When backuping Pg 9.5, there is no issue, but backuping Pg 9.6 > afterwards will say

[HACKERS] Bug with pg_basebackup and 'shared' tablespace

Hi On our servers, we are running different PostgreSQL versions because we can not migrate every application at the same time to Pg 9.6… Since we have several disks, we use tablespaces and, for historical reasons, we used the same folder for both Pg versions, say /mnt/ssd/postgres The server