Re: [HACKERS] COPY command with RLS bug

2016-10-03 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sat, Oct 1, 2016 at 3:11 AM, Stephen Frost wrote: > > Comments and testing welcome, of course, though it's looking pretty good > > to me at this point and I'll likely commit it in another day or two > > unless issues

Re: [HACKERS] COPY command with RLS bug

2016-10-01 Thread Michael Paquier
On Sat, Oct 1, 2016 at 3:11 AM, Stephen Frost wrote: > Comments and testing welcome, of course, though it's looking pretty good > to me at this point and I'll likely commit it in another day or two > unless issues are found. +* nodes/value.h) that

Re: [HACKERS] COPY command with RLS bug

2016-09-30 Thread Stephen Frost
Adam, Michael, * Adam Brightwell (adam.brightw...@crunchydata.com) wrote: > > Looking for and improving test coverage for RLS is a good suggestion, > > but let's not link the fate of the issue reported here with this > > requirement. I have spent some time looking at this patch and this > > looks

Re: [HACKERS] COPY command with RLS bug

2016-09-10 Thread Adam Brightwell
> Looking for and improving test coverage for RLS is a good suggestion, > but let's not link the fate of the issue reported here with this > requirement. I have spent some time looking at this patch and this > looks in rather good shape to me (you even remembered to use the > prefix regress_* for

Re: [HACKERS] COPY command with RLS bug

2016-09-10 Thread Michael Paquier
On Sat, Sep 10, 2016 at 3:55 AM, Adam Brightwell wrote: >> Perhaps we should extend rowsecurity test with a more comprehensive >> set of tests rather than just fix the COPY one? > > I think more tests that provide value are always a *good* thing, > however, would

Re: [HACKERS] COPY command with RLS bug

2016-09-09 Thread Adam Brightwell
> Thanks for the report and the fix. Yup. I have added it to the 2016-11 commitfest: https://commitfest.postgresql.org/11/794/ > This seems a rather basic error to occur a year after release. > > Is this a problem with the testing of RLS? What other RLS related > failures exist in other

Re: [HACKERS] COPY command with RLS bug

2016-09-09 Thread Simon Riggs
On 8 September 2016 at 20:13, Adam Brightwell wrote: > I have discovered a bug with the COPY command, specifically related to RLS. ... > Connecting as a non-privileged user provides the following results: ... > COPY foo (a, b, c) TO stdout; -- fail > ERROR:

[HACKERS] COPY command with RLS bug

2016-09-08 Thread Adam Brightwell
All, I have discovered a bug with the COPY command, specifically related to RLS. The issue: When running COPY as superuser on a table that has RLS enabled, RLS is bypassed and therefore no issue exists. However, when performing a COPY as a non-privileged user on the same table causes issues