[HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Andres Freund
On 2014-05-14 15:17:39 +0200, Andres Freund wrote: On 2014-05-14 15:08:08 +0200, Tomas Vondra wrote: Apparently there's something wrong with 'test-decoding-check': Man. I shouldn't have asked... My code. There's some output in there that's probably triggered by the extraordinarily long

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-05-14 15:17:39 +0200, Andres Freund wrote: My gut feeling says it's in RelationGetIndexList(). Nearly right. It's in RelationGetIndexAttrBitmap(). Fix attached. TBH, I don't believe this patch at all. Where exactly is rd_replidindex reset?

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Andres Freund
On 2014-05-14 12:15:27 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-05-14 15:17:39 +0200, Andres Freund wrote: My gut feeling says it's in RelationGetIndexList(). Nearly right. It's in RelationGetIndexAttrBitmap(). Fix attached. TBH, I don't believe this

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Andres Freund
On 2014-05-14 13:32:43 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-05-14 12:15:27 -0400, Tom Lane wrote: And why does the header comment for RelationGetIndexList make no mention of this new side-effect? Somebody did a seriously poor job of adding this

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-05-14 12:15:27 -0400, Tom Lane wrote: And why does the header comment for RelationGetIndexList make no mention of this new side-effect? Somebody did a seriously poor job of adding this functionality to relcache. It's not like it's not

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Tomas Vondra
On 14.5.2014 17:52, Andres Freund wrote: On 2014-05-14 15:17:39 +0200, Andres Freund wrote: On 2014-05-14 15:08:08 +0200, Tomas Vondra wrote: Apparently there's something wrong with 'test-decoding-check': Man. I shouldn't have asked... My code. There's some output in there that's probably

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Andres Freund
Hi, On 2014-05-14 21:04:41 +0200, Tomas Vondra wrote: On 14.5.2014 17:52, Andres Freund wrote: On 2014-05-14 15:17:39 +0200, Andres Freund wrote: On 2014-05-14 15:08:08 +0200, Tomas Vondra wrote: Apparently there's something wrong with 'test-decoding-check': Man. I shouldn't have

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Tomas Vondra
On 14.5.2014 22:29, Andres Freund wrote: Hi, On 2014-05-14 21:04:41 +0200, Tomas Vondra wrote: On 14.5.2014 17:52, Andres Freund wrote: On 2014-05-14 15:17:39 +0200, Andres Freund wrote: On 2014-05-14 15:08:08 +0200, Tomas Vondra wrote: Apparently there's something wrong with

Re: [HACKERS] Cache invalidation bug in RelationGetIndexAttrBitmap()

2014-05-14 Thread Tom Lane
Tomas Vondra t...@fuzzy.cz writes: On 14.5.2014 22:29, Andres Freund wrote: I'm afraid it's more in the year range from what i've seen. I.e. not practical. Yeah, that wouldn't be very practical. I'll try to run it though and if it'd run more than a few days, I'll switch it to