On mån, 2011-05-09 at 14:58 -0400, Bruce Momjian wrote:
Tom this collation stuff has seen more post-feature-commit cleanups
than I think any patch I remember. Is there anything we can learn
from this?
Don't do big patches?
Seriously, it looks pretty bad, but this is one of the biggest
Peter Eisentraut wrote:
from that? The bigger your patch, the lonelier you are.
I can attest to that.
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
--
Sent
Peter Eisentraut pete...@gmx.net writes:
Seriously, it looks pretty bad, but this is one of the biggest feature
patches in the last 5 years, it touches many places all over the system,
and there is a reason why this topic has been on the TODO list for 10
years: it's overwhelming.
Yeah. I did
On Mon, May 09, 2011 at 03:57:12PM -0400, Robert Haas wrote:
On Mon, May 9, 2011 at 2:58 PM, Bruce Momjian br...@momjian.us wrote:
Tom this collation stuff has seen more post-feature-commit cleanups than
I think any patch I remember. Is there anything we can learn from this?
How about
On Tuesday, May 10, 2011 07:08:23 PM Ross J. Reedstrom wrote:
On Mon, May 09, 2011 at 03:57:12PM -0400, Robert Haas wrote:
On Mon, May 9, 2011 at 2:58 PM, Bruce Momjian br...@momjian.us wrote:
Tom this collation stuff has seen more post-feature-commit cleanups
than I think any patch I
On Tue, May 10, 2011 at 07:21:16PM +0200, Andres Freund wrote:
On Tuesday, May 10, 2011 07:08:23 PM Ross J. Reedstrom wrote:
On Mon, May 09, 2011 at 03:57:12PM -0400, Robert Haas wrote:
On Mon, May 9, 2011 at 2:58 PM, Bruce Momjian br...@momjian.us wrote:
Tom this collation stuff has
Ross J. Reedstrom reeds...@rice.edu writes:
So perhaps it was more of the This code is less ready than I thought
it was, but now that I've spent the time understanding it and the
problem, the shortest way out is forward.
Yeah, exactly. By the time I really understood how incomplete the
Tom this collation stuff has seen more post-feature-commit cleanups than
I think any patch I remember. Is there anything we can learn from this?
Yes, this is coming from me, who some consider to be the king of
post-commit cleanups, namely, cleaning up my own commits.
Bruce Momjian br...@momjian.us writes:
Tom this collation stuff has seen more post-feature-commit cleanups than
I think any patch I remember. Is there anything we can learn from this?
The pre-commit review was obviously woefully inadequate.
regards, tom lane
--
Sent
On Mon, May 9, 2011 at 2:58 PM, Bruce Momjian br...@momjian.us wrote:
Tom this collation stuff has seen more post-feature-commit cleanups than
I think any patch I remember. Is there anything we can learn from this?
How about don't commit all the large patches at the end of the cycle?
--
10 matches
Mail list logo
