Re: [HACKERS] Commitfest process

2008-03-08 Thread Heikki Linnakangas
Brendan Jurd wrote: But I also agree with Josh Drake's comment about a single point of entry. If patch authors are updating the wiki, and reviewers are using the wiki to guide their efforts, what purpose does the -patches mailing list serve? Does sending an email to -patches on top of

[HACKERS] Commitfest process

2008-03-07 Thread Heikki Linnakangas
It's not clear how this commitfest thing is supposed to work in practice. May I suggest that: 1. When a patch author wants to have a patch reviewed in the next commitfest, he posts it to pgsql-patches as usual, and then adds it to the list on the Todo:PatchStatus page (or perhaps even better,

Re: [HACKERS] Commitfest process

2008-03-07 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 07 Mar 2008 14:33:02 + Heikki Linnakangas [EMAIL PROTECTED] wrote: It's not clear how this commitfest thing is supposed to work in practice. May I suggest that: 1. When a patch author wants to have a patch reviewed in the next

Re: [HACKERS] Commitfest process

2008-03-07 Thread Heikki Linnakangas
Joshua D. Drake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 07 Mar 2008 14:33:02 + Heikki Linnakangas [EMAIL PROTECTED] wrote: It's not clear how this commitfest thing is supposed to work in practice. May I suggest that: 1. When a patch author wants to have a patch

Re: [HACKERS] Commitfest process

2008-03-07 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 07 Mar 2008 18:46:24 + Heikki Linnakangas [EMAIL PROTECTED] wrote: I think we'll have more success convincing patch authors to update a wiki page, than we'll have to convince reviewers to do so. I know that's true at least for me. If

Re: [HACKERS] Commitfest process

2008-03-07 Thread Alvaro Herrera
Joshua D. Drake wrote: On Fri, 07 Mar 2008 18:46:24 + Heikki Linnakangas [EMAIL PROTECTED] wrote: I think we'll have more success convincing patch authors to update a wiki page, than we'll have to convince reviewers to do so. I know that's true at least for me. If I want people to

Re: [HACKERS] Commitfest process

2008-03-07 Thread Heikki Linnakangas
Alvaro Herrera wrote: Joshua D. Drake wrote: On Fri, 07 Mar 2008 18:46:24 + Heikki Linnakangas [EMAIL PROTECTED] wrote: I think we'll have more success convincing patch authors to update a wiki page, than we'll have to convince reviewers to do so. I know that's true at least for me. If

Re: [HACKERS] Commitfest process

2008-03-07 Thread Andrew Chernow
Heikki Linnakangas wrote: The main point of my proposal is: let's make the *authors* who want their stuff to be reviewed as part of a commitfest do the extra work. There would be no extra work required for patch reviewers. I think this makes the most sense. It distributes the work to

Re: [HACKERS] Commitfest process

2008-03-07 Thread Magnus Hagander
Heikki Linnakangas wrote: Alvaro Herrera wrote: Joshua D. Drake wrote: On Fri, 07 Mar 2008 18:46:24 + Heikki Linnakangas [EMAIL PROTECTED] wrote: I think we'll have more success convincing patch authors to update a wiki page, than we'll have to convince reviewers to do so. I know

Re: [HACKERS] Commitfest process

2008-03-07 Thread Robert Lor
Heikki Linnakangas wrote: The main point of my proposal is: let's make the *authors* who want their stuff to be reviewed as part of a commitfest do the extra work. There would be no extra work required for patch reviewers. I agree with Heikki that for the process to be successful, it should

Re: [HACKERS] Commitfest process

2008-03-07 Thread Andrew Dunstan
Andrew Chernow wrote: Heikki Linnakangas wrote: The main point of my proposal is: let's make the *authors* who want their stuff to be reviewed as part of a commitfest do the extra work. There would be no extra work required for patch reviewers. I think this makes the most sense. It

Re: [HACKERS] Commitfest process

2008-03-07 Thread Greg Smith
On Fri, 7 Mar 2008, Heikki Linnakangas wrote: If I want people to review my patch, I'm ready to sing and dance if that's what it takes. Great timing, there's even a suitable song available for you today: http://use.perl.org/~grantm/journal/35855 -- * Greg Smith [EMAIL PROTECTED]

Re: [HACKERS] Commitfest process

2008-03-07 Thread Robert Lor
Tom Lane wrote: This is reasonable for the sort of medium-to-large patch that the author has put a lot of time into. But we also get a lot of small one-off patches where it's not so reasonable. Now of course many of those get applied right away, but not all. One of the services that Bruce's

Re: [HACKERS] Commitfest process

2008-03-07 Thread Andrew Chernow
This is reasonable for the sort of medium-to-large patch that the author has put a lot of time into. But we also get a lot of small one-off patches where it's not so reasonable. Now of course many of those get applied right away, but not all. Just a thought... maybe a distinction should

Re: [HACKERS] Commitfest process

2008-03-07 Thread Brendan Jurd
On 08/03/2008, Heikki Linnakangas [EMAIL PROTECTED] wrote: I think we'll have more success convincing patch authors to update a wiki page, than we'll have to convince reviewers to do so. I know that's true at least for me. If I want people to review my patch, I'm ready to sing and dance if