Re: [HACKERS] Compiler warnings fix

2009-01-27 Thread Magnus Hagander
ITAGAKI Takahiro wrote: > Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c. > > There are following warnings if nls is enabled: > pg_locale.c: In function `pg_perm_setlocale': > pg_locale.c:161: warning: assignment discards qualifiers from pointer > target typ

Re: [HACKERS] Compiler warnings fix

2009-01-26 Thread Tom Lane
Andrew Dunstan writes: >> There are same warning on vaquita in buildfarm. >> http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2009-01-26%20210011&stg=make > Wouldn't we be better off using defined(ENABLE_NLS) instead of > defined(LC_MESSAGES) ? No, because the purpose of that

Re: [HACKERS] Compiler warnings fix

2009-01-26 Thread Andrew Dunstan
ITAGAKI Takahiro wrote: Peter Eisentraut wrote: ITAGAKI Takahiro wrote: Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c. There are following warnings if nls is enabled: pg_locale.c: In function `pg_perm_setlocale': pg_locale.c:161: warning: ass

Re: [HACKERS] Compiler warnings fix

2009-01-26 Thread ITAGAKI Takahiro
Peter Eisentraut wrote: > ITAGAKI Takahiro wrote: > > Here is a patch to surpress compiler warnings in pg_locale.c and > > pg_regress.c. > > > > There are following warnings if nls is enabled: > > pg_locale.c: In function `pg_perm_setlocale': > > pg_locale.c:161: warning: assignment di

Re: [HACKERS] Compiler warnings fix

2009-01-26 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c. There are following warnings if nls is enabled: pg_locale.c: In function `pg_perm_setlocale': pg_locale.c:161: warning: assignment discards qualifiers from pointer target type and if n

[HACKERS] Compiler warnings fix

2009-01-25 Thread ITAGAKI Takahiro
Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c. There are following warnings if nls is enabled: pg_locale.c: In function `pg_perm_setlocale': pg_locale.c:161: warning: assignment discards qualifiers from pointer target type and if nls is disabled: pg_loc