Peter Eisentraut pete...@gmx.net writes:
I think you are mistaken. My patch includes all changes between your v1
and v2 patch.
I mistakenly remembered that we did remove all the is_event_trigger
business from the plperl patch too, when it's not the case. Sorry about
this confusion.
My vote is
On 12/11/13, 5:06 AM, Dimitri Fontaine wrote:
Peter Eisentraut pete...@gmx.net writes:
I think you are mistaken. My patch includes all changes between your v1
and v2 patch.
I mistakenly remembered that we did remove all the is_event_trigger
business from the plperl patch too, when it's not
On Mon, 2013-12-09 at 09:45 +0100, Dimitri Fontaine wrote:
It looks like you started with the v1 of the plperl patch rather than
the v2, where the only difference is in only using is_trigger or using
both is_trigger and is_event_trigger. Your version currently uses both
where I though we chose
Peter Eisentraut pete...@gmx.net writes:
I think this is wrong, and the reason it crashes if you remove it is
that you need to call increment_prodesc_refcount(prodesc), like in the
other handlers.
Thanks, looks like this indeed.
Attached is my final patch. Let me know if it's OK for you.
On Tue, 2013-11-26 at 06:59 -0500, Peter Eisentraut wrote:
Attached is my final patch. Let me know if it's OK for you.
Dimitri, will you have a change to review this?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
I made one significant change in the PL/Perl patch. You had this in
plperl_event_trigger_handler():
+ /*
+* Create the call_data before connecting to SPI, so that it is not
+* allocated in the SPI memory context
+*/
+ current_call_data = (plperl_call_data *)
Peter Eisentraut pete...@gmx.net writes:
I have committed the PL/Tcl part.
I'll work on the PL/Perl part next.
Thanks!
I believe we're still waiting on something from you for PL/Python.
Yes I still need to figure that one out.
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL :
I have committed the PL/Tcl part.
I'll work on the PL/Perl part next.
I believe we're still waiting on something from you for PL/Python.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Hi,
Thanks for your review, sorry about the delays in answering, I've been
quite busy with other matters recently, it seems like things are going
to be smoother this week.
Peter Eisentraut pete...@gmx.net writes:
Review of the PL/Tcl part: The functionality looks OK. There are some
cosmetic
On Fri, 2013-09-13 at 22:40 +0200, Dimitri Fontaine wrote:
Please find attached to this email three patches covering the missing PL
support for Event Triggers: pltcl, plperl and plpython.
For plperl, the previous reviews mostly apply analogously. In addition,
I have these specific points:
-
Review of the PL/Tcl part: The functionality looks OK. There are some
cosmetic issues. If those are addressed, I think this can be committed.
In the documentation, Event Triggers - Event triggers.
For the example in the documentation, please show the output, that is,
what the trigger outputs.
Peter Eisentraut wrote:
In the source code, I'm dubious about the use of is_dml_trigger. I can
see where you are coming from, but in most of the code, a trigger is a
trigger and an event trigger is an event trigger. Let's not introduce
more terminology.
Other opinions on that?
I'm with
On Fri, 2013-09-13 at 22:40 +0200, Dimitri Fontaine wrote:
Please find attached to this email three patches covering the missing PL
support for Event Triggers: pltcl, plperl and plpython.
You introduced some new compiler warnings, please fix those.
Hi,
Please find attached to this email three patches covering the missing PL
support for Event Triggers: pltcl, plperl and plpython.
Due to “platform” problems here tonight and the CF deadline, the
plpython patch is known not to pass regression tests on my machine. The
code is fully rebased and
14 matches
Mail list logo
