Re: [HACKERS] Confusing TAP tests readme file

2016-07-26 Thread Fujii Masao
On Mon, Jul 25, 2016 at 9:53 PM, Michael Paquier wrote: > On Mon, Jul 25, 2016 at 7:42 PM, Ildar Musin wrote: >> I was checking out TAP tests documentation. And I found confusing this part >> of src/test/perl/README file: >> >> my $ret =

Re: [HACKERS] Confusing TAP tests readme file

2016-07-25 Thread Michael Paquier
On Mon, Jul 25, 2016 at 7:42 PM, Ildar Musin wrote: > I was checking out TAP tests documentation. And I found confusing this part > of src/test/perl/README file: > > my $ret = $node->psql('postgres', 'SELECT 1'); > is($ret, '1', 'SELECT 1 returns 1'); Good catch.

[HACKERS] Confusing TAP tests readme file

2016-07-25 Thread Ildar Musin
Hi all, I was checking out TAP tests documentation. And I found confusing this part of src/test/perl/README file: my $ret = $node->psql('postgres', 'SELECT 1'); is($ret, '1', 'SELECT 1 returns 1'); The returning value of psql() function is the exit code of the psql. Hence this test