Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-22 Thread Alexander Korotkov
On Tue, Oct 22, 2013 at 2:00 AM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Tom Lane t...@sss.pgh.pa.us writes: I believe the reason GIST has compress/decompress functions is not for TOAST (they predate that, if memory serves), but to allow the on-disk representation of an index entry

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-21 Thread Heikki Linnakangas
On 11.10.2013 17:39, Alexander Korotkov wrote: On Fri, Oct 11, 2013 at 5:56 PM, Heikki Linnakangashlinnakan...@vmware.com wrote: 2. I didn't understand this change: @@ -422,24 +439,14 @@ g_cube_union(PG_FUNCTION_ARGS) Datum g_cube_compress(PG_FUNCTION_**ARGS) { -

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-21 Thread Alexander Korotkov
On Mon, Oct 21, 2013 at 11:06 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 11.10.2013 17:39, Alexander Korotkov wrote: On Fri, Oct 11, 2013 at 5:56 PM, Heikki Linnakangashlinnakangas@** vmware.com hlinnakan...@vmware.com wrote: 2. I didn't understand this change: @@

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-21 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: On Mon, Oct 21, 2013 at 11:06 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I guess it can't happen. Or is it possible that a toasted value that came from disk will be passed to these functions, without detoasting them somewhere along

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-21 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I believe the reason GIST has compress/decompress functions is not for TOAST (they predate that, if memory serves), but to allow the on-disk representation of an index entry to be different from the data type's normal representation in other ways --- think

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-11 Thread Heikki Linnakangas
On 09.10.2013 21:07, Robert Haas wrote: On Tue, Sep 24, 2013 at 9:07 AM, Stas Kelvichstas.kelv...@gmail.com wrote: Hello There is new version of patch. I have separated ordering operators to different patch (https://commitfest.postgresql.org/action/patch_view?id=1243), fixed formatting

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-11 Thread Alexander Korotkov
On Fri, Oct 11, 2013 at 5:56 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: 2. I didn't understand this change: @@ -422,24 +439,14 @@ g_cube_union(PG_FUNCTION_ARGS) Datum g_cube_compress(PG_FUNCTION_**ARGS) { - PG_RETURN_DATUM(PG_GETARG_**DATUM(0)); + GISTENTRY

Re: [HACKERS] Cube extension point support // GSoC'13

2013-10-09 Thread Robert Haas
On Tue, Sep 24, 2013 at 9:07 AM, Stas Kelvich stas.kelv...@gmail.com wrote: Hello There is new version of patch. I have separated ordering operators to different patch (https://commitfest.postgresql.org/action/patch_view?id=1243), fixed formatting issues and implemented backward

Re: [HACKERS] Cube extension point support // GSoC'13

2013-09-24 Thread Stas Kelvich
Hello There is new version of patch. I have separated ordering operators to different patch (https://commitfest.postgresql.org/action/patch_view?id=1243), fixed formatting issues and implemented backward compatibility with old-style points in cube_is_point() and cube_out(). Also comparing

Re: [HACKERS] Cube extension point support // GSoC'13

2013-09-16 Thread Heikki Linnakangas
On 12.07.2013 14:57, Stas Kelvich wrote: Hello. here is a patch adding to cube extension support for compressed representation of point cubes. If cube is a point, i.e. has coincident lower left and upper right corners, than only one corner is stored. First bit of the cube header indicates

Re: [HACKERS] Cube extension point support // GSoC'13

2013-07-17 Thread Alexander Korotkov
On Fri, Jul 12, 2013 at 3:57 PM, Stas Kelvich stas.kelv...@gmail.comwrote: Hello. here is a patch adding to cube extension support for compressed representation of point cubes. If cube is a point, i.e. has coincident lower left and upper right corners, than only one corner is stored. First