Re: [HACKERS] Don't include MMAP DSM's transient files in basebackup

2016-07-07 Thread Andres Freund
On 2016-07-07 08:49:18 +0100, Magnus Hagander wrote: > On Thursday, July 7, 2016, Andres Freund wrote: > > > On 2016-07-06 16:46:53 +0300, Oskari Saarenmaa wrote: > > > The files are not useful when restoring a backup and would be > > automatically > > > deleted on startup

Re: [HACKERS] Don't include MMAP DSM's transient files in basebackup

2016-07-07 Thread Magnus Hagander
On Thursday, July 7, 2016, Andres Freund wrote: > On 2016-07-06 16:46:53 +0300, Oskari Saarenmaa wrote: > > The files are not useful when restoring a backup and would be > automatically > > deleted on startup anyway. Also deleted an out-of-date comment in dsm.c. > > No

Re: [HACKERS] Don't include MMAP DSM's transient files in basebackup

2016-07-07 Thread Andres Freund
Hi, On 2016-07-06 16:46:53 +0300, Oskari Saarenmaa wrote: > The files are not useful when restoring a backup and would be automatically > deleted on startup anyway. Also deleted an out-of-date comment in dsm.c. No arguments against the change. But I am wondering how you ran into this - the mmap

Re: [HACKERS] Don't include MMAP DSM's transient files in basebackup

2016-07-07 Thread Michael Paquier
On Wed, Jul 6, 2016 at 10:46 PM, Oskari Saarenmaa wrote: > The files are not useful when restoring a backup and would be automatically > deleted on startup anyway. The same could be said about pg_snapshots. -- Michael -- Sent via pgsql-hackers mailing list

[HACKERS] Don't include MMAP DSM's transient files in basebackup

2016-07-06 Thread Oskari Saarenmaa
The files are not useful when restoring a backup and would be automatically deleted on startup anyway. Also deleted an out-of-date comment in dsm.c. / Oskari >From f26f06049b5f89ca3140462d6816259268322d78 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa Date: Wed, 6 Jul 2016