Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-16 Thread Michael Meskes
OK, here's another approach. output_statement()'s interface is kept as the original, and not this function decides which I still think this could be solved more easily. value it uses. I also introduced static char *ecpg_statement_type_name[] for the textual names of the ECPGst_* symbols

Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-16 Thread Boszormenyi Zoltan
Michael Meskes írta: OK, here's another approach. output_statement()'s interface is kept as the original, and not this function decides which I still think this could be solved more easily. Thanks very much for committing it. But I don't understand your change. My code was:

Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-16 Thread Michael Meskes
On Wed, Dec 16, 2009 at 11:54:41AM +0100, Boszormenyi Zoltan wrote: Your code in ecpg.addons calls output_statement() unconditionally with ECPGst_prepnormal and output_statement() decides what to do with the auto_prepare global variable. Your code doesn't seem more readable than mine, but

Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-15 Thread Boszormenyi Zoltan
Hi, here's another patch that aims to fix auto-prepare. The reason is, that in the project porting from Informix, a small test case that used a cursor and two small SELECTs issued for every record retrieved by the cursor showed that for this case, the ESQL compiled binary finished about 60%

Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-15 Thread Michael Meskes
On Tue, Dec 15, 2009 at 02:19:19PM +0100, Boszormenyi Zoltan wrote: here's another patch that aims to fix auto-prepare. ... --- pgsql.6/src/interfaces/ecpg/preproc/output.c 2009-12-15 13:12:37.0 +0100 *** hashline_number(void) *** 106,112 } void !

Re: [HACKERS] ECPG patch N+1, fix auto-prepare

2009-12-15 Thread Boszormenyi Zoltan
Michael Meskes írta: On Tue, Dec 15, 2009 at 02:19:19PM +0100, Boszormenyi Zoltan wrote: here's another patch that aims to fix auto-prepare. ... --- pgsql.6/src/interfaces/ecpg/preproc/output.c 2009-12-15 13:12:37.0 +0100 *** hashline_number(void) *** 106,112