Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-09 Thread Michael Paquier
On Thu, Mar 9, 2017 at 10:43 PM, Peter Eisentraut wrote: > On 3/8/17 02:34, Michael Paquier wrote: >> This patch looks good to me. > > committed Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-09 Thread Peter Eisentraut
On 3/8/17 02:34, Michael Paquier wrote: > This patch looks good to me. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-07 Thread Michael Paquier
On Wed, Mar 8, 2017 at 11:29 AM, Peter Eisentraut wrote: > On 3/6/17 21:11, Michael Paquier wrote: >> I think that the documentation of initdb should mention that >> pg_hba.conf entries are configured for replication connections as >> well, something like a

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-07 Thread Peter Eisentraut
On 3/6/17 21:11, Michael Paquier wrote: > I think that the documentation of initdb should mention that > pg_hba.conf entries are configured for replication connections as > well, something like a sentence in the Description paragraph: > initdb sets pg_hba.conf entries using the specified

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-06 Thread Michael Paquier
On Tue, Mar 7, 2017 at 5:03 AM, Peter Eisentraut wrote: > On 3/3/17 20:30, Michael Paquier wrote: >> Yeah, it looks sensible to me to keep "replication" for physical >> replication, and switch logical replication checks to match a database >> name in hba

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-06 Thread Peter Eisentraut
On 3/3/17 20:30, Michael Paquier wrote: > Yeah, it looks sensible to me to keep "replication" for physical > replication, and switch logical replication checks to match a database > name in hba comparisons. I think we are OK to move ahead with this. Another question would be why only enable

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-03 Thread Michael Paquier
On Sat, Mar 4, 2017 at 9:47 AM, Magnus Hagander wrote: > On Thursday, March 2, 2017, Peter Eisentraut > wrote: >> >> On 2/3/17 17:47, Michael Paquier wrote: >> > On Fri, Feb 3, 2017 at 4:59 AM, Simon Riggs >> > wrote:

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-03 Thread Magnus Hagander
On Thursday, March 2, 2017, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/3/17 17:47, Michael Paquier wrote: > > On Fri, Feb 3, 2017 at 4:59 AM, Simon Riggs > wrote: > >>> It's weirdly inconsistent now. You need a "replication" line in

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-03-02 Thread Peter Eisentraut
On 2/3/17 17:47, Michael Paquier wrote: > On Fri, Feb 3, 2017 at 4:59 AM, Simon Riggs wrote: >>> It's weirdly inconsistent now. You need a "replication" line in >>> pg_hba.conf to connect for logical decoding, but you can't restrict that >>> to a specific database because

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-06 Thread Peter Eisentraut
On 2/2/17 2:59 PM, Simon Riggs wrote: > We currently have REPLICATION to mean "physical replication". Well, it doesn't really mean that. The same facilities are used to control access to both logical and physical replication. > I think if we have another capability for logical replication then

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-03 Thread Michael Paquier
On Fri, Feb 3, 2017 at 4:59 AM, Simon Riggs wrote: > On 2 February 2017 at 18:48, Peter Eisentraut > wrote: >> On 2/2/17 8:32 AM, Simon Riggs wrote: >>> I think we should remove the "replication" false database concept in >>> pg_hba.conf

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-02 Thread Simon Riggs
On 2 February 2017 at 18:48, Peter Eisentraut wrote: > On 2/2/17 8:32 AM, Simon Riggs wrote: >> I think we should remove the "replication" false database concept in >> pg_hba.conf altogether and allow any valid pg_hba rule to invoke a >> replication connection,

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-02 Thread Peter Eisentraut
On 2/2/17 8:32 AM, Simon Riggs wrote: > I think we should remove the "replication" false database concept in > pg_hba.conf altogether and allow any valid pg_hba rule to invoke a > replication connection, if one is requested. Roles would still need > the REPLICATION capability before this would be

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-02 Thread Petr Jelinek
On 02/02/17 14:32, Simon Riggs wrote: > On 23 January 2017 at 04:29, Michael Paquier > wrote: >> Hi all, >> >> As now wal_level = replica has become the default for Postgres 10, >> could we consider as well making replication connections enabled by >> default in

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-02 Thread Simon Riggs
On 23 January 2017 at 04:29, Michael Paquier wrote: > Hi all, > > As now wal_level = replica has become the default for Postgres 10, > could we consider as well making replication connections enabled by > default in pg_hba.conf? Agreed > This requires just

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-02 Thread Magnus Hagander
On Thu, Feb 2, 2017 at 6:08 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 1/22/17 10:29 PM, Michael Paquier wrote: > > As now wal_level = replica has become the default for Postgres 10, > > could we consider as well making replication connections enabled by > > default in

Re: [HACKERS] Enabling replication connections by default in pg_hba.conf

2017-02-01 Thread Peter Eisentraut
On 1/22/17 10:29 PM, Michael Paquier wrote: > As now wal_level = replica has become the default for Postgres 10, > could we consider as well making replication connections enabled by > default in pg_hba.conf? This requires just uncommenting a couple of > lines in pg_hba.conf.sample. Yes, I think

[HACKERS] Enabling replication connections by default in pg_hba.conf

2017-01-22 Thread Michael Paquier
Hi all, As now wal_level = replica has become the default for Postgres 10, could we consider as well making replication connections enabled by default in pg_hba.conf? This requires just uncommenting a couple of lines in pg_hba.conf.sample. Thanks, -- Michael pghba_rep_default.patch