Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-07-12 Thread Michael Paquier
On Sun, Jul 13, 2014 at 2:39 AM, Magnus Hagander > Applied, thanks!. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-07-12 Thread Magnus Hagander
On Mon, Jun 30, 2014 at 1:43 PM, Michael Paquier wrote: > > > > On Mon, Jun 30, 2014 at 7:05 PM, Asif Naeem wrote: >> Patch looks good to me. I think it is ready for committer. Thanks. > Thanks for the extra checks and for taking the time to review it. Applied, thanks! -- Magnus Hagander Me

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-30 Thread Michael Paquier
On Mon, Jun 30, 2014 at 7:05 PM, Asif Naeem wrote: > Patch looks good to me. I think it is ready for committer. Thanks. Thanks for the extra checks and for taking the time to review it. -- Michael On Mon, Jun 30, 2014 at 7:05 PM, Asif Naeem wrote: Thank you for sharing up

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-30 Thread Asif Naeem
Thank you for sharing updated patch. I have compared it with MSVC and configure generated build i.e. *MacOSX (*--with-extra-version "-30JUN"*)* pc1dotnetpk:inst asif$ ./bin/psql -d postgres > psql (9.5devel-30JUN) > Type "help" for help. > postgres=# select version(); >

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-26 Thread Michael Paquier
On Fri, Jun 27, 2014 at 8:26 AM, Asif Naeem wrote: > I have spent some time reviewing the code. It applies well and PG master > branch build fine with setting extraver or keep it undefined. > Thanks for reviewing that. > I have observed the following output applying the patch i.e. > It seems th

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-06-26 Thread Asif Naeem
Hi, I have spent some time reviewing the code. It applies well and PG master branch build fine with setting extraver or keep it undefined. I have observed the following output applying the patch i.e. *Keeping extraver undefined* : C:\PG\postgresql\inst_withpatch_no_extra-version>bin\psql.exe -d

[HACKERS] Extending MSVC scripts to support --with-extra-version

2014-05-26 Thread Michael Paquier
Hi all, Please find attached a patch extending support of --with-extra-version in the MSVC scripts. This is something I have been using internally, and I believe that it is useful for Windows packagers. Similarly to the other options, a new field called extraver is added in config_default.pl and i