Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-04 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: Committed. Thanks! -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread David E. Wheeler
On Jan 1, 2011, at 2:30 PM, Dimitri Fontaine wrote: To support that is quite simple in fact, as the following commands will do the trick: CREATE WRAPPER EXTENSION ...;-- don't run the script ALTER OBJECT ... SET EXTENSION ...; -- that's in the upgrade script ALTER EXTENSION ...

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread Dimitri Fontaine
David E. Wheeler da...@kineticode.com writes: I rather doubt that WRAPPER will be accepted as a reserved word in the grammar. It's already in the grammar, and I didn't change its level. dim=# create wrapper extension lo; CREATE EXTENSION What happened to your UPGRADE from NULL idea? You

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread David E. Wheeler
On Jan 3, 2011, at 11:49 AM, Dimitri Fontaine wrote: David E. Wheeler da...@kineticode.com writes: I rather doubt that WRAPPER will be accepted as a reserved word in the grammar. It's already in the grammar, and I didn't change its level. Okay. dim=# create wrapper extension lo; CREATE

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread Dimitri Fontaine
David E. Wheeler da...@kineticode.com writes: That's what I understood your original UPGRADE from NULL being. Did I misread you? Are the docs about the feature, available handy in HTML so that you don't have to read them in SGML at my git repository, are they *that* bad?

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread David E. Wheeler
On Jan 3, 2011, at 11:54 AM, Dimitri Fontaine wrote: That's what I understood your original UPGRADE from NULL being. Did I misread you? Are the docs about the feature, available handy in HTML so that you don't have to read them in SGML at my git repository, are they *that* bad?

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread Dimitri Fontaine
David E. Wheeler da...@kineticode.com writes: http://pgsql.tapoueh.org/extensions/doc/html/extend-extension.html I was responding to your email mentioning it, which did not reference said docs. Fair enough, I'm still interested in you telling me if I get to rewrite them all or if it's

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-03 Thread Robert Haas
On Sun, Jan 2, 2011 at 6:43 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Dimitri Fontaine dimi...@2ndquadrant.fr writes:   make -C contrib/citext install   psql -f .../head/share/contrib/citext.sql   psql   dim=# do $$ begin execute 'alter operator class public.citext_ops using btree

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-02 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: The problem occurs on ALTER OPERATOR FAMILY ... SET EXTENSION, that's what dichotomy on the citext.upgrade.sql tells me. The code in question was copy/pasted from the SET SCHEMA code path in gram.y then other related files. So I just tested a

Re: [HACKERS] Extension upgrade, patch v0: debug help needed

2011-01-02 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: make -C contrib/citext install psql -f .../head/share/contrib/citext.sql psql dim=# do $$ begin execute 'alter operator class public.citext_ops using btree set schema utils'; end; $$; server closed the connection unexpectedly