Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-09-05 Thread Greg Stark
On Sun, Jul 26, 2015 at 11:15 PM, Peter Geoghegan wrote: > The SQLite people have been using a tool like this for some time. > They've also had luck finding bugs with a generic fuzz-testing tool > called "american fuzzy lop" (yes, seriously, that's what it's called), > which apparently is the stat

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-30 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> Bottom line is that somebody failed to consider the possibility of a > >> null comparison value reaching the BRIN index lookup machinery. > >> The code stanza that's failing supposes that only IS NULL or IS NOT NULL > >> tests could

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-28 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Bottom line is that somebody failed to consider the possibility of a >> null comparison value reaching the BRIN index lookup machinery. >> The code stanza that's failing supposes that only IS NULL or IS NOT NULL >> tests could have SK_ISNULL set, but tha

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-28 Thread Alvaro Herrera
Tom Lane wrote: > Bottom line is that somebody failed to consider the possibility of a > null comparison value reaching the BRIN index lookup machinery. > The code stanza that's failing supposes that only IS NULL or IS NOT NULL > tests could have SK_ISNULL set, but that's just wrong. I think the

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-27 Thread Tom Lane
Andreas Seltenreich writes: > I let sqlsmith run during the night, and it did no longer trigger the > first two. During roughly a million random queries it triggered the > already mentioned brin one 10 times, but there was also one instance of > this new one in the log: > TRAP: FailedAssertion("

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-27 Thread Tom Lane
Andreas Seltenreich writes: > Tom Lane writes: >> I've fixed the first two of these --- thanks for the report! > I let sqlsmith run during the night, and it did no longer trigger the > first two. During roughly a million random queries it triggered the > already mentioned brin one 10 times, but

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-27 Thread Alvaro Herrera
Tom Lane wrote: > Bottom line is that somebody failed to consider the possibility of a > null comparison value reaching the BRIN index lookup machinery. > The code stanza that's failing supposes that only IS NULL or IS NOT NULL > tests could have SK_ISNULL set, but that's just wrong. Hm, okay, wi

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Andreas Seltenreich
Tom Lane writes: > Andreas Seltenreich writes: >> when running my random query generator contraption[1] against the >> regression database of 9.5 or master, it occasionally triggers one of >> the following three assertions. > > I've fixed the first two of these --- thanks for the report! I let s

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Michael Paquier
On Sun, Jul 26, 2015 at 10:32 PM, Andreas Seltenreich wrote: > Michael Paquier writes: > > >> Footnotes: > >> [1] https://github.com/anse1/sqlsmith > > > > This is really interesting stuff. I think that it would be possible to > > extract self-contained test cases from your tool and those querie

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Peter Geoghegan
On Sun, Jul 26, 2015 at 7:07 AM, Tom Lane wrote: > Andreas Seltenreich writes: >> when running my random query generator contraption[1] against the >> regression database of 9.5 or master, it occasionally triggers one of >> the following three assertions. > > Very very cool tool! Please keep doi

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Tom Lane
Andreas Seltenreich writes: > when running my random query generator contraption[1] against the > regression database of 9.5 or master, it occasionally triggers one of > the following three assertions. I've fixed the first two of these --- thanks for the report! > ,[ git bisect ] > | first

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Tom Lane
Andreas Seltenreich writes: > when running my random query generator contraption[1] against the > regression database of 9.5 or master, it occasionally triggers one of > the following three assertions. Very very cool tool! Please keep doing that testing. The first two seem to be planner problem

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Andreas Seltenreich
Michael Paquier writes: >> Footnotes: >> [1] https://github.com/anse1/sqlsmith > > This is really interesting stuff. I think that it would be possible to > extract self-contained test cases from your tool and those queries to > reproduce the failures. It is written that this tools connects to a >

Re: [HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Michael Paquier
On Sun, Jul 26, 2015 at 9:55 PM, Andreas Seltenreich wrote: > when running my random query generator contraption[1] against the > regression database of 9.5 or master, it occasionally triggers one of > the following three assertions. Someone more knowledgeable might want > to take a look at them.

[HACKERS] Failing assertions in indxpath.c, placeholder.c and brin_minmax.c

2015-07-26 Thread Andreas Seltenreich
Hi, when running my random query generator contraption[1] against the regression database of 9.5 or master, it occasionally triggers one of the following three assertions. Someone more knowledgeable might want to take a look at them... -- FailedAssertion("!(outer_rel->rows > 0)", File: "indxpath