Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-14 Thread Oleg Bartunov
Thanks, Bruce ! Oleg On Thu, 13 Aug 2009, Bruce Momjian wrote: Peter Eisentraut wrote: On Thursday 13 August 2009 18:07:51 Alvaro Herrera wrote: Oleg Bartunov wrote: Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? aacute; for ?, etc. You can't

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-13 Thread Robert Haas
On Tue, Aug 11, 2009 at 4:31 AM, Peter Eisentrautpete...@gmx.net wrote: On Tuesday 11 August 2009 08:28:24 Jaime Casanova wrote: try to build the docs to see how to properly test this and seems like you have to teach contrib.sgml and bookindex.sgml about dict-unaccent... and when i did that i

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-13 Thread Oleg Bartunov
Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? Oleg On Tue, 11 Aug 2009, Peter Eisentraut wrote: On Tuesday 11 August 2009 08:28:24 Jaime Casanova wrote: try to build the docs to see how to properly test this and seems like you have to teach

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-13 Thread Alvaro Herrera
Oleg Bartunov wrote: Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? aacute; for á, etc. You can't use characters that aren't in Latin-1 I think. Writing them literally is not allowed. -- Alvaro Herrera

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-13 Thread Peter Eisentraut
On Thursday 13 August 2009 18:07:51 Alvaro Herrera wrote: Oleg Bartunov wrote: Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? aacute; for á, etc. You can't use characters that aren't in Latin-1 I think. Writing them literally is not allowed.

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-13 Thread Bruce Momjian
Peter Eisentraut wrote: On Thursday 13 August 2009 18:07:51 Alvaro Herrera wrote: Oleg Bartunov wrote: Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? aacute; for ?, etc. You can't use characters that aren't in Latin-1 I think. Writing

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-11 Thread Peter Eisentraut
On Tuesday 11 August 2009 08:28:24 Jaime Casanova wrote: try to build the docs to see how to properly test this and seems like you have to teach contrib.sgml and bookindex.sgml about dict-unaccent... and when i did that i got this: openjade -wall -wno-unused-param -wno-empty -wfully-tagged

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-10 Thread Jaime Casanova
On Fri, Aug 7, 2009 at 10:44 AM, Jaime Casanovajcasa...@systemguards.com.ec wrote: On Thu, Aug 6, 2009 at 10:46 PM, Robert Haasrobertmh...@gmail.com wrote: I am not sure whether this has been formally reviewed by anyone yet; do we think it's Ready for Committer? i was trying to make some

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-07 Thread Jaime Casanova
On Thu, Aug 6, 2009 at 10:46 PM, Robert Haasrobertmh...@gmail.com wrote: I am not sure whether this has been formally reviewed by anyone yet; do we think it's Ready for Committer? i was trying to make some review of this but besides that it compiles fine and passes regression tests doesn't

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-06 Thread Teodor Sigaev
Isn't that function leaking res pointer? Also, I'm curious why you're fixed allocating 2*sizeof(TSLexeme) in unaccent_lexize ... That's is a dictionary's interface part: lexize returns an array of TSLexeme and last structure should have lexeme field NULL. filter_dictionary file is not

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-06 Thread Robert Haas
2009/8/6 Teodor Sigaev teo...@sigaev.ru: Isn't that function leaking res pointer?  Also, I'm curious why you're fixed allocating 2*sizeof(TSLexeme) in unaccent_lexize ... That's is a dictionary's interface part: lexize returns an array of TSLexeme and last structure should have lexeme

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-04 Thread Robert Haas
On Sat, Aug 1, 2009 at 12:35 AM, Alvaro Herreraalvhe...@commandprompt.com wrote: Teodor Sigaev wrote: As for the contrib module, I think it could use a lot more function header comments!  Also, it would be great if it could be used separately from tsearch, i.e. that it provided a function

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-31 Thread Alvaro Herrera
Teodor Sigaev wrote: As for the contrib module, I think it could use a lot more function header comments! Also, it would be great if it could be used separately from tsearch, i.e. that it provided a function unaccent(text) returns text that unaccented arbitrary strings (I guess it would use

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-29 Thread Peter Eisentraut
On Tuesday 14 July 2009 22:12:28 Oleg Bartunov wrote: we'd like to introduce filtering dictionaries support for text search and new contrib module unaccent, which provides useful example of filtering dictionary. It finally solves the known problem of incorrect generation of headlines of text

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-29 Thread Oleg Bartunov
On Wed, 29 Jul 2009, Peter Eisentraut wrote: On Tuesday 14 July 2009 22:12:28 Oleg Bartunov wrote: we'd like to introduce filtering dictionaries support for text search and new contrib module unaccent, which provides useful example of filtering dictionary. It finally solves the known problem

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-28 Thread Teodor Sigaev
I'm curious about the pg_regress change ... is it really necessary? To test unaccent dictionary it's needed to input accented characters, not all encodings allow that. UTF8 allows that, but it doesn't compatible with a lot of locales. So, --no-locale should be propagated to CREATE DATABASE

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-15 Thread Alvaro Herrera
Oleg Bartunov wrote: Hi, we'd like to introduce filtering dictionaries support for text search and new contrib module unaccent, which provides useful example of filtering dictionary. It finally solves the known problem of incorrect generation of headlines of text with accents. I'm

[HACKERS] Filtering dictionaries support and unaccent dictionary

2009-07-14 Thread Oleg Bartunov
Hi there, we'd like to introduce filtering dictionaries support for text search and new contrib module unaccent, which provides useful example of filtering dictionary. It finally solves the known problem of incorrect generation of headlines of text with accents. Also, this module provides