Re: [HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > I have applied the attached patch to fix pg_upgrade file descriptor > > leaks in error paths. > > It seems rather pointless to spend code closing descriptors immediately > before a fatal exit. Well, it is not before a fatal but rather before it returns

Re: [HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Tom Lane
Bruce Momjian writes: > I have applied the attached patch to fix pg_upgrade file descriptor > leaks in error paths. It seems rather pointless to spend code closing descriptors immediately before a fatal exit. regards, tom lane -- Sent via pgsql-hackers mailing list (pgs

[HACKERS] Fix for pg_upgrade discriptor leaks

2011-03-08 Thread Bruce Momjian
I have applied the attached patch to fix pg_upgrade file descriptor leaks in error paths. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + diff --git a/contrib/pg_upgrade/check.c b/co