Re: [HACKERS] Found small issue with OUT params

2005-10-01 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] on behalf of Bruce Momjian Sent: Sat 10/1/2005 1:16 AM To: Jim C. Nasby Cc: Joshua D. Drake; Tony Caduto; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Found small issue with OUT params fix pgxs for spaces in file names I posted

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Tony Caduto
Tom Lane wrote: Mike Rylander [EMAIL PROTECTED] writes: Using that logic, a functions with one OUT param would be the same as a function returning a rowtype with only one column, But it's not (and no, I don't want to make it so, because the overhead for the useless record result

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Martijn van Oosterhout
On Fri, Sep 30, 2005 at 10:20:34AM -0500, Tony Caduto wrote: Tom, I hardly think the overhead would be significant on modern processors, I don't think the majority of users are running on Pentium 90s.( I am assuming you mean a performance overhead) Um, please read the documention. Returning

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Tony Caduto
Martijn van Oosterhout wrote: On Fri, Sep 30, 2005 at 10:20:34AM -0500, Tony Caduto wrote: Tom, I hardly think the overhead would be significant on modern processors, I don't think the majority of users are running on Pentium 90s.( I am assuming you mean a performance overhead) Um,

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Joshua D. Drake
So you might notice little performance hit bringing back a million rows, and most of these type of single OUT params functions only return one row/value anyway. There would be zero perceivable difference in performance regardless of the extra overhead for a single value/row. Sounds like we

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Robert Treat
On Friday 30 September 2005 11:49, Martijn van Oosterhout wrote: On Fri, Sep 30, 2005 at 10:20:34AM -0500, Tony Caduto wrote: Tom, I hardly think the overhead would be significant on modern processors, I don't think the majority of users are running on Pentium 90s.( I am assuming you mean

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Jim C. Nasby
On Fri, Sep 30, 2005 at 10:53:22AM -0700, Joshua D. Drake wrote: So you might notice little performance hit bringing back a million rows, and most of these type of single OUT params functions only return one row/value anyway. There would be zero perceivable difference in performance

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Bruce Momjian
Jim C. Nasby wrote: On Fri, Sep 30, 2005 at 10:53:22AM -0700, Joshua D. Drake wrote: So you might notice little performance hit bringing back a million rows, and most of these type of single OUT params functions only return one row/value anyway. There would be zero perceivable

Re: [HACKERS] Found small issue with OUT params

2005-09-30 Thread Mike Rylander
On 9/30/05, Jim C. Nasby [EMAIL PROTECTED] wrote: On Fri, Sep 30, 2005 at 10:53:22AM -0700, Joshua D. Drake wrote: So you might notice little performance hit bringing back a million rows, and most of these type of single OUT params functions only return one row/value anyway. There

Re: [HACKERS] Found small issue with OUT params

2005-09-29 Thread Tony Caduto
Tom Lane wrote: Tony Caduto [EMAIL PROTECTED] writes: Please don't take this the wrong way, but don't you think even if a single param is declared as OUT it should return the name of the OUT param? Not really, because create function foo (in x int, out y float) is supposed to have

Re: [HACKERS] Found small issue with OUT params

2005-09-29 Thread Mike Rylander
On 9/29/05, Tom Lane [EMAIL PROTECTED] wrote: Tony Caduto [EMAIL PROTECTED] writes: Please don't take this the wrong way, but don't you think even if a single param is declared as OUT it should return the name of the OUT param? Not really, because create function foo (in x int, out y float)

Re: [HACKERS] Found small issue with OUT params

2005-09-29 Thread Tom Lane
Mike Rylander [EMAIL PROTECTED] writes: Using that logic, a functions with one OUT param would be the same as a function returning a rowtype with only one column, But it's not (and no, I don't want to make it so, because the overhead for the useless record result would be significant).

[HACKERS] Found small issue with OUT params

2005-09-28 Thread Tony Caduto
Hi, consider this function: CREATE OR REPLACE FUNCTION FIND_USER_SOCKET_BYNAME ( IN IN_USERNAME VARCHAR, OUT OUT_SOCKET_ADDRESS INTEGER) AS $BODY$ BEGIN select socket_address from userdata where fullname = in_username into out_socket_address; if out_socket_address is

Re: [HACKERS] Found small issue with OUT params

2005-09-28 Thread Tom Lane
Tony Caduto [EMAIL PROTECTED] writes: If I call it like this: select * from FIND_USER_SOCKET_BYNAME('juser'); I would expect to get back 1 value with the name of the OUT param (OUT_SOCKET_ADDRESS). However it comes back with the name of the function This is intentional, for compatibility

Re: [HACKERS] Found small issue with OUT params

2005-09-28 Thread Tony Caduto
Tom Lane wrote: Tony Caduto [EMAIL PROTECTED] writes: If I call it like this: select * from FIND_USER_SOCKET_BYNAME('juser'); I would expect to get back 1 value with the name of the OUT param (OUT_SOCKET_ADDRESS). However it comes back with the name of the function This is

Re: [HACKERS] Found small issue with OUT params

2005-09-28 Thread Tom Lane
Tony Caduto [EMAIL PROTECTED] writes: Please don't take this the wrong way, but don't you think even if a single param is declared as OUT it should return the name of the OUT param? Not really, because create function foo (in x int, out y float) is supposed to have the same external behavior

Re: [HACKERS] Found small issue with OUT params

2005-09-28 Thread Bruce Momjian
Tom Lane wrote: Tony Caduto [EMAIL PROTECTED] writes: Please don't take this the wrong way, but don't you think even if a single param is declared as OUT it should return the name of the OUT param? Not really, because create function foo (in x int, out y float) is supposed to have the