a_ogawa <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> Based on this I think we ought to go with the "unrolled" approach,
> I agree. The unrolled approach is a good result in most environments.
I have committed changes along this line in HEAD and 8_0 branches.
> First of all, this macro will
Tom Lane wrote:
> Based on this I think we ought to go with the "unrolled" approach, ie,
> we'll create a macro to initialize the fixed fields of fcinfo but fill
> in the arg and argisnull arrays with code like what's already in
> FunctionCall2:
I agree. The unrolled approach is a good result in
Sorry, forgot the compiler version.
gcc (GCC) 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
On Wed, 2 Feb 2005 01:12:04 +, Mike Rylander <[EMAIL PROTECTED]> wrote:
> On Tue, 01 Feb 2005 16:23:56 -0500, Tom Lane <[EMAIL PROTECTED]> wrote:
> > a_ogawa <[EMAIL PROTECTED]> writes
On Tue, 01 Feb 2005 16:23:56 -0500, Tom Lane <[EMAIL PROTECTED]> wrote:
> a_ogawa <[EMAIL PROTECTED]> writes:
> > I made the test program to measure the effect of this macro.
>
> Well, if we're going to be tense about this, let's actually be tense
> about it. Your test program isn't a great model
On February 1, 2005 01:23 pm, Tom Lane wrote:
> a_ogawa <[EMAIL PROTECTED]> writes:
> > I made the test program to measure the effect of this macro.
>
> Well, if we're going to be tense about this, let's actually be tense
> about it. Your test program isn't a great model for what's going to
> happ
a_ogawa <[EMAIL PROTECTED]> writes:
> I made the test program to measure the effect of this macro.
Well, if we're going to be tense about this, let's actually be tense
about it. Your test program isn't a great model for what's going to
happen in fmgr.c, because you've designed it so that Nargs c
Tom Lane wrote:
> Neil Conway <[EMAIL PROTECTED]> writes:
> > I agree; I think the macro is a nice improvement to readability.
>
> But a dead loss for performance, since it does a MemSet *and* some other
> operations. What's worse, it changes a word-aligned MemSet into a
> n
Neil Conway <[EMAIL PROTECTED]> writes:
> On Mon, 2005-01-31 at 23:38 +0900, a_ogawa wrote:
>> (b)Define the macro that initialize FunctionCallInfoData, and use it
>> instead of MemSet in all FunctionCallN, DirectFunctionCallN,
>> OidFunctionCallN.
>> This macro is the following.
>>
>> #define
On Mon, 2005-01-31 at 23:38 +0900, a_ogawa wrote:
> (b)Define the macro that initialize FunctionCallInfoData, and use it
> instead of MemSet in all FunctionCallN, DirectFunctionCallN,
> OidFunctionCallN.
> This macro is the following.
>
> #define InitFunctionCallInfoData(Fcinfo, Flinfo, Nargs)
When SQL that returns many tuples with character code conversion
is executed, the FunctionCall3/FunctionCall5 becomes a bottleneck.
Because MemSet is used to initialize FunctionCallInfoData in these
functions, a lot of cycles are spent.
set client_encoding to 'SJIS';
sel
10 matches
Mail list logo
