Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-09-30 Thread Magnus Hagander
On Thu, Sep 30, 2010 at 04:40, Itagaki Takahiro itagaki.takah...@gmail.com wrote: Hi, I have a question about the latest patch. On Sun, Aug 22, 2010 at 11:03 PM, Quan Zongliang quanzongli...@gmail.com wrote: New patch attached. How about this? I don't see us ever using anything other than

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-09-29 Thread Itagaki Takahiro
Hi, I have a question about the latest patch. On Sun, Aug 22, 2010 at 11:03 PM, Quan Zongliang quanzongli...@gmail.com wrote: New patch attached. How about this? I don't see us ever using anything other than auto or demand. The others aren't for regular services + set_starttype(char

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-24 Thread Quan Zongliang
Which files need be modified? sgml, html, and man-page or only sgml? I am not familiar with this. On Sun, 22 Aug 2010 08:25:59 -0700 David Fetter da...@fetter.org wrote: On Sun, Aug 22, 2010 at 10:03:32PM +0800, Quan Zongliang wrote: Sure, I agree. New patch attached. How about this?

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-24 Thread Magnus Hagander
On Tue, Aug 24, 2010 at 2:05 PM, Quan Zongliang quanzongli...@gmail.com wrote: Which files need be modified? sgml, html, and man-page or only sgml? I am not familiar with this. Only SGML. HTML and man pages are generated from the SGML. --  Magnus Hagander  Me: http://www.hagander.net/  

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-22 Thread Quan Zongliang
Sure, I agree. New patch attached. How about this? On Fri, 20 Aug 2010 11:21:18 +0200 Magnus Hagander mag...@hagander.net wrote: On Fri, Aug 20, 2010 at 01:01, Quan Zongliang quanzongli...@gmail.com wrote: Because Windows's CreateService has serial start-type: SERVICE_AUTO_START

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-22 Thread David Fetter
On Sun, Aug 22, 2010 at 10:03:32PM +0800, Quan Zongliang wrote: Sure, I agree. New patch attached. How about this? Docs re-added. Please not to leave these out in future patches. :) Cheers, David. -- David Fetter da...@fetter.org http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-20 Thread Magnus Hagander
On Fri, Aug 20, 2010 at 01:01, Quan Zongliang quanzongli...@gmail.com wrote: Because Windows's CreateService has serial start-type: SERVICE_AUTO_START SERVICE_BOOT_START SERVICE_DEMAND_START SERVICE_DISABLED SERVICE_SYSTEM_START Although all of them are not useful for pg service. I think

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread David Fetter
On Thu, Aug 19, 2010 at 10:24:54PM +0800, Quan Zongliang wrote: documents attached. html and man-page Thanks! For future reference, the way to patch docs is by patching the SGML source. Please find enclosed a patch which incorporates the code patch you sent with these docs. Cheers, David. --

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread Alvaro Herrera
Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010: +varlistentry + termoption-S replaceable class=parameter/replaceable/option/term You omitted the start-type inside the replaceable tag. Also, the a and d values seem to be accepted but not documented. --

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread David Fetter
On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote: Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010: +varlistentry + termoption-S replaceable class=parameter/replaceable/option/term You omitted the start-type inside the replaceable tag.

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread Alvaro Herrera
Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010: On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote: Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010: +varlistentry + termoption-S replaceable

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread David Fetter
On Thu, Aug 19, 2010 at 04:48:53PM -0400, Alvaro Herrera wrote: Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010: On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote: Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010: +

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread Quan Zongliang
Because Windows's CreateService has serial start-type: SERVICE_AUTO_START SERVICE_BOOT_START SERVICE_DEMAND_START SERVICE_DISABLED SERVICE_SYSTEM_START Although all of them are not useful for pg service. I think it is better to use enum. On Thu, 19 Aug 2010 16:48:53 -0400 Alvaro Herrera

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-19 Thread Quan Zongliang
I don't know how to edit documents exactly before. Thanks. On Thu, 19 Aug 2010 08:48:53 -0700 David Fetter da...@fetter.org wrote: On Thu, Aug 19, 2010 at 10:24:54PM +0800, Quan Zongliang wrote: documents attached. html and man-page Thanks! For future reference, the way to patch docs

[HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-17 Thread Quan Zongliang
Sorry. I forget to attach the patch file. Begin forwarded message: Date: Mon, 16 Aug 2010 19:49:20 +0800 From: Quan Zongliang quanzongli...@gmail.com To: pgsql-hackers@postgresql.org Subject: patch for pg_ctl.c to add windows service start-type Hi, all I modified pg_ctl.c to add a new option

Re: [HACKERS] Fw: patch for pg_ctl.c to add windows service start-type

2010-08-17 Thread Magnus Hagander
On Tue, Aug 17, 2010 at 2:58 PM, Quan Zongliang quanzongli...@gmail.com wrote: Sorry. I forget to attach the patch file. Without looking at the details of this patch, it looks reasonable - so please put it on the commitfest page, if you haven't already. It does, however, lack documentation