Re: [HACKERS] GetSnapshotData() comments

2012-08-23 Thread Bruce Momjian
On Tue, Aug 21, 2012 at 11:48:19AM -0400, Robert Haas wrote: > On Tue, Aug 14, 2012 at 5:41 PM, Bruce Momjian wrote: > > Did these comment updates ever get addressed? > > Partially. > > I just made a commit to clean up the rest of it. Thanks. -- Bruce Momjian http://momjian.us En

Re: [HACKERS] GetSnapshotData() comments

2012-08-21 Thread Robert Haas
On Tue, Aug 14, 2012 at 5:41 PM, Bruce Momjian wrote: > Did these comment updates ever get addressed? Partially. I just made a commit to clean up the rest of it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] GetSnapshotData() comments

2012-08-14 Thread Bruce Momjian
Did these comment updates ever get addressed? --- On Fri, Aug 5, 2011 at 11:02:24AM -0400, Robert Haas wrote: > I think that the first sentence, in the following comment within > GetSnapshotData(), is not quite right, becau

[HACKERS] GetSnapshotData() comments

2011-08-05 Thread Robert Haas
I think that the first sentence, in the following comment within GetSnapshotData(), is not quite right, because at the time this is executed, we already hold ProcArrayLock, which is the only lock that gets grabbed here: /* * If we're in recovery then snapshot data comes from a dif