Re: [HACKERS] Getting available options

2008-02-21 Thread Magnus Hagander
On Thu, Feb 21, 2008 at 09:15:13AM -0300, Alvaro Herrera wrote: > Magnus Hagander wrote: > > > > I like the idea that was mentioned upthread of creating a new "enum" > > > category for GUC variables, instead of continuing to abuse the rather > > > inefficient "string" category for the purpose. On

Re: [HACKERS] Getting available options

2008-02-21 Thread Alvaro Herrera
Magnus Hagander wrote: > > I like the idea that was mentioned upthread of creating a new "enum" > > category for GUC variables, instead of continuing to abuse the rather > > inefficient "string" category for the purpose. One reason is that > > we then would not be faced with making an incompatibl

Re: [HACKERS] Getting available options

2008-02-21 Thread Magnus Hagander
On Wed, Feb 20, 2008 at 05:59:27PM -0500, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Tue, 2008-02-19 at 14:22 +0100, Magnus Hagander wrote: > >> I'd like to add a way for a client (in this case, typicallyi pgadmin, > >> phppgadmin or similar) to get the available options on th

Re: [HACKERS] Getting available options

2008-02-20 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Tue, 2008-02-19 at 14:22 +0100, Magnus Hagander wrote: >> I'd like to add a way for a client (in this case, typicallyi pgadmin, >> phppgadmin or similar) to get the available options on the server for the >> GUC settings we have that take fixed options.

Re: [HACKERS] Getting available options

2008-02-20 Thread Simon Riggs
On Tue, 2008-02-19 at 14:22 +0100, Magnus Hagander wrote: > I'd like to add a way for a client (in this case, typicallyi pgadmin, > phppgadmin or similar) to get the available options on the server for the > GUC settings we have that take fixed options. This is to make it possible > to generate pre

Re: [HACKERS] Getting available options

2008-02-19 Thread Magnus Hagander
On Tue, Feb 19, 2008 at 11:17:51AM -0300, Alvaro Herrera wrote: > Magnus Hagander wrote: > > > That would work for all the settings here I think, except for > > log_destinatino > > which actually supports multiple choices from the enumeration. But that > > would be fairly easy to implement on top

Re: [HACKERS] Getting available options

2008-02-19 Thread Alvaro Herrera
Magnus Hagander wrote: > That would work for all the settings here I think, except for log_destinatino > which actually supports multiple choices from the enumeration. But that > would be fairly easy to implement on top of it. I think DateStyle should also be considered carefully, given how it ha

Re: [HACKERS] Getting available options

2008-02-19 Thread Gevik Babakhani
> I like option 1 the best. Minimally invasive, and probably > easier to handle on the client than 2. +1 ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [HACKERS] Getting available options

2008-02-19 Thread Magnus Hagander
On Tue, Feb 19, 2008 at 02:56:42PM +0100, Peter Eisentraut wrote: > Am Dienstag, 19. Februar 2008 schrieb Magnus Hagander: > > 1) Extend pg_settings with a column that contains an array of the available > > options. Extend the config_string GUC struct with a hook that can return > > this data. > >

Re: [HACKERS] Getting available options

2008-02-19 Thread Peter Eisentraut
Am Dienstag, 19. Februar 2008 schrieb Magnus Hagander: > 1) Extend pg_settings with a column that contains an array of the available > options. Extend the config_string GUC struct with a hook that can return > this data. Before we get to the interface for reporting this to the client, I wonder how

Re: [HACKERS] Getting available options

2008-02-19 Thread Dave Page
On Feb 19, 2008 1:22 PM, Magnus Hagander <[EMAIL PROTECTED]> wrote: > I'd like to add a way for a client (in this case, typicallyi pgadmin, > phppgadmin or similar) to get the available options on the server for the > GUC settings we have that take fixed options. This is to make it possible > to ge

[HACKERS] Getting available options

2008-02-19 Thread Magnus Hagander
I'd like to add a way for a client (in this case, typicallyi pgadmin, phppgadmin or similar) to get the available options on the server for the GUC settings we have that take fixed options. This is to make it possible to generate pretty dropdown lists of the options. One way would be to simply pre