Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2012-08-16 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue ago 16 11:24:55 -0400 2012: > On Mon, Oct 17, 2011 at 08:38:18PM +0100, Simon Riggs wrote: > > On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > > > Alvaro Herrera writes: > > >> I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2012-08-16 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue ago 16 11:44:48 -0400 2012: > On Thu, Aug 16, 2012 at 11:38:14AM -0400, Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of jue ago 16 11:24:55 -0400 2012: > > > On Mon, Oct 17, 2011 at 08:38:18PM +0100, Simon Riggs wrote: > > > > On Mon,

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2012-08-16 Thread Bruce Momjian
On Thu, Aug 16, 2012 at 11:38:14AM -0400, Alvaro Herrera wrote: > Excerpts from Bruce Momjian's message of jue ago 16 11:24:55 -0400 2012: > > On Mon, Oct 17, 2011 at 08:38:18PM +0100, Simon Riggs wrote: > > > On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > > > > Alvaro Herrera writes: > > > >

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2012-08-16 Thread Bruce Momjian
On Mon, Oct 17, 2011 at 08:38:18PM +0100, Simon Riggs wrote: > On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > > Alvaro Herrera writes: > >> I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing > >> Xmax as a TransactionId without verifying whether it is a multixact or > >

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-18 Thread Simon Riggs
On Tue, Oct 18, 2011 at 3:14 AM, Alvaro Herrera wrote: >> I'll add an assert to check this and a comment to explain. > > This means I'll have to hack it up further in my FK locks patch.  No problem > with that. OK, I'll hold back to avoid interfering with your patch. --  Simon Riggs  

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-17 Thread Alvaro Herrera
At Monday, 10/17/2011 on 4:38 pm Simon Riggs wrote: > On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > > Alvaro Herrera writes: > >> I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing > >> Xmax as a TransactionId without verifying whether it is a multixact or > >> not.

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-17 Thread Simon Riggs
On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > Alvaro Herrera writes: >> I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing Xmax >> as a TransactionId without verifying whether it is a multixact or not.   >> Since they advance separately, this could lead to bogus answers

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-17 Thread Simon Riggs
On Mon, Oct 17, 2011 at 8:03 PM, Tom Lane wrote: > Alvaro Herrera writes: >> I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing Xmax >> as a TransactionId without verifying whether it is a multixact or not.   >> Since they advance separately, this could lead to bogus answers

Re: [HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-17 Thread Tom Lane
Alvaro Herrera writes: > I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing Xmax > as a TransactionId without verifying whether it is a multixact or not. Since > they advance separately, this could lead to bogus answers. This probably > needs to be fixed. I didn't look i

[HACKERS] HeapTupleHeaderAdvanceLatestRemovedXid doing the wrong thing with multixacts

2011-10-17 Thread Alvaro Herrera
I just noticed that HeapTupleHeaderAdvanceLatestRemovedXid is comparing Xmax as a TransactionId without verifying whether it is a multixact or not. Since they advance separately, this could lead to bogus answers. This probably needs to be fixed. I didn't look into past releases to see if ther