Re: [HACKERS] Hstore: Query speedups with Gin index

2013-11-30 Thread Peter Eisentraut
Are you still working on this patch? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-15 Thread David Fetter
Blake, I've taken the liberty of adding this patch to the current Commitfest. In future, please continue to send patches both to this thread and to the commitfest application when you have a message ID for them :) Cheers, David. On Mon, Sep 09, 2013 at 09:55:01AM -0500, Blake Smith wrote:

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-10 Thread Oleg Bartunov
Blake, Teodor will review your patch, but I have one consideration about the patch in context of future hstore, which supports hierarchical structures. In that case overhead of composite keys will be enormous and the only way in this direction is to think about idea suffix array instead of btree

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-09 Thread Blake Smith
Thanks for getting back to me about this change Oleg. I took your advice and reworked the patch by adding a new hstore gin opclass (gin_hstore_combined_ops) and leaving the functionality of the default hstore gin opclass the same. This should prevent the on-disk compatibility issues from the first

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-06 Thread Oleg Bartunov
Blake, I think it's better to implement this patch as a separate opclass, so users will have option to choose indexing. Oleg On Tue, Sep 3, 2013 at 6:24 PM, Blake Smith blakesmi...@gmail.com wrote: Thanks for the feedback everyone. I've attached the patch that we are now running in

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-06 Thread Peter Eisentraut
On 9/5/13 2:42 PM, Blake Smith wrote: Thanks for checking the tests. I wasn't able to duplicate your test results. Did you run the hstore regression tests with the revised patch I attached in the thread? Attached is the output I got with the latest patch applied. See

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-05 Thread Blake Smith
Hi Peter, Thanks for checking the tests. I wasn't able to duplicate your test results. Did you run the hstore regression tests with the revised patch I attached in the thread? Attached is the output I got with the latest patch applied. Thanks! Blake On Tue, Sep 3, 2013 at 8:04 PM, Peter

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-09-03 Thread Blake Smith
Thanks for the feedback everyone. I've attached the patch that we are now running in production to service our hstore include queries. We rebuilt the index to account for the on-disk incompatibility. I've submitted the patch to commitfest here:

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-08-28 Thread Bruce Momjian
On Sun, Aug 25, 2013 at 10:11:50PM -0400, Tom Lane wrote: Michael Paquier michael.paqu...@gmail.com writes: On Thu, Aug 22, 2013 at 11:55 PM, Blake Smith blakesmi...@gmail.com wrote: The combined entry is used to support contains (@) queries, and the key only item is used to support key

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-08-28 Thread Andres Freund
On 2013-08-28 13:31:22 -0400, Bruce Momjian wrote: On Sun, Aug 25, 2013 at 10:11:50PM -0400, Tom Lane wrote: Michael Paquier michael.paqu...@gmail.com writes: On Thu, Aug 22, 2013 at 11:55 PM, Blake Smith blakesmi...@gmail.com wrote: The combined entry is used to support contains (@)

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-08-26 Thread Oleg Bartunov
Michael, take a look on http://obartunov.livejournal.com/171959.html As for the indexing stuff we already thought many times about keyvalue mixing, but real solution, probably, could come from spgist and gin combination. I mean, spgist (suffix array) instead of btree for avoiding key

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-08-25 Thread Michael Paquier
On Thu, Aug 22, 2013 at 11:55 PM, Blake Smith blakesmi...@gmail.com wrote: We've been experiencing slow @ queries involving an hstore column that's covered by a Gin index. At the current postgresql git HEAD, the hstore - gin interface produces the following text items to be indexed: hstore:

Re: [HACKERS] Hstore: Query speedups with Gin index

2013-08-25 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Thu, Aug 22, 2013 at 11:55 PM, Blake Smith blakesmi...@gmail.com wrote: The combined entry is used to support contains (@) queries, and the key only item is used to support key contains (?) queries. This change seems to help especially with

[HACKERS] Hstore: Query speedups with Gin index

2013-08-22 Thread Blake Smith
Hey everyone, I'm looking for feedback on a contrib/hstore patch. We've been experiencing slow @ queries involving an hstore column that's covered by a Gin index. At the current postgresql git HEAD, the hstore - gin interface produces the following text items to be indexed: hstore: 'a'='1234',