Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-15 Thread Arthur Zakirov
2017-03-14 15:55 GMT+03:00 Ashutosh Bapat : > > I noticed that the earlier error message was using "server" instead of > "foreign server", while the new message uses the later one. Usually, > when converting an error to notice, we don't expect such changes. But >

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-14 Thread Ashutosh Bapat
> > Thanks for catching that. > It was caused by a conflict on applying of the patch. > Updated versions of both patches are attached. > We do not need extra line + + other usages of this do not have an extra line. Removed the extra line in the attached patch. I noticed that the earlier

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Artur Zakirov
On 13.03.2017 13:01, Anastasia Lubennikova wrote: Thanks for catching that. It was caused by a conflict on applying of the patch. Updated versions of both patches are attached. I think the code is good and the patches are small. Documentation is updated by the patches. All regression

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Anastasia Lubennikova
13.03.2017 11:53, Artur Zakirov: On 15.02.2017 20:54, Anastasia Lubennikova wrote: Done. I have gotten the error that AlterUserMappingStmt doesn't have if_not_exists (in Russian): gram.y: В функции «base_yyparse»: gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-03-13 Thread Artur Zakirov
On 15.02.2017 20:54, Anastasia Lubennikova wrote: Done. I have gotten the error that AlterUserMappingStmt doesn't have if_not_exists (in Russian): gram.y: В функции «base_yyparse»: gram.y:4918:7: ошибка: «AlterUserMappingStmt {aka struct AlterUserMappingStmt}» не содержит элемента с

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-02-15 Thread Anastasia Lubennikova
13.02.2017 19:34, Andrew Dunstan: On 01/13/2017 08:36 AM, Anastasia Lubennikova wrote: I implemented IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements for one of our customers. I think other users can also find it useful for scripting and automated tasks. The patches

Re: [HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-02-13 Thread Andrew Dunstan
On 01/13/2017 08:36 AM, Anastasia Lubennikova wrote: > I implemented IF NOT EXISTS option for CREATE SERVER and CREATE USER > MAPPING statements > for one of our customers. > I think other users can also find it useful for scripting and > automated tasks. > The patches themselves are small and

[HACKERS] IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements

2017-01-13 Thread Anastasia Lubennikova
I implemented IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements for one of our customers. I think other users can also find it useful for scripting and automated tasks. The patches themselves are small and simple. Documentation is updated as well. -- Anastasia