[HACKERS] Improved error message for CREATE EXTENSION patch...

2013-06-04 Thread Sean Chittenden
I ran in to the following situation: SET search_path = ENOENT, also_does_not_exist; CREATE EXTENSION pg_repack; ERROR: XX000: there is no default creation target LOCATION: CreateExtension, extension.c:1395 Which left me checking out the source code to figure out exactly what the problem

Re: [HACKERS] Improved error message for CREATE EXTENSION patch...

2013-06-04 Thread Tom Lane
Sean Chittenden s...@chittenden.org writes: I ran in to the following situation: SET search_path = ENOENT, also_does_not_exist; CREATE EXTENSION pg_repack; ERROR: XX000: there is no default creation target LOCATION: CreateExtension, extension.c:1395 Which left me checking out the source

Re: [HACKERS] Improved error message for CREATE EXTENSION patch...

2013-06-04 Thread Sean Chittenden
ERROR: XX000: no schemas in search_path are available for CREATE EXTENSION Hm, I'm not sure that's much better than the existing wording. The bigger point here though is that if we consider this to be a user-facing error case, it ought to be ereport not elog. I checked what you get

Re: [HACKERS] Improved error message for CREATE EXTENSION patch...

2013-06-04 Thread Tom Lane
Sean Chittenden s...@chittenden.org writes: Seems like we ought to use the same message (and SQLSTATE) as in namespace.c, since nobody's complained about that one. Sounds good to me and is clear enough that it would unblock me w/o having to resort to the source tree. -sc OK, done that way.