Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-08-17 Thread Andrew Gierth
> "Thomas" == Thomas Munro writes: >> [...] >> T_NamedTuplestoreScan can be produced by outfuncs.c with tagname >> NAMEDTUPLESTORESCAN but that tagname is not recognized by readfuncs.c >> [...] >> >> That revealed a defect in commit >> 18ce3a4ab22d2984f8540ab480979c851dae5338 which I

Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-08-17 Thread Thomas Munro
On Fri, Jul 14, 2017 at 1:46 PM, Thomas Munro wrote: > [...] > T_NamedTuplestoreScan can be produced by outfuncs.c with tagname > NAMEDTUPLESTORESCAN but that tagname is not recognized by readfuncs.c > [...] > > That revealed a defect in commit > 18ce3a4ab22d2984f8540ab480979c851dae5338 which I th

Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-07-25 Thread Thomas Munro
On Wed, Jul 26, 2017 at 4:04 PM, Thomas Munro wrote: > On Wed, Jul 26, 2017 at 6:35 AM, Robert Haas wrote: >> That's pretty cool. Per long-standing precedent, anything we use in a >> build needs to be in Perl, not Python, but I think it would be great >> to fix all of these (or the script) and t

Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-07-25 Thread Thomas Munro
On Wed, Jul 26, 2017 at 6:35 AM, Robert Haas wrote: > That's pretty cool. Per long-standing precedent, anything we use in a > build needs to be in Perl, not Python, but I think it would be great > to fix all of these (or the script) and then add this to our standard > build process. It would be

Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-07-25 Thread Robert Haas
On Thu, Jul 13, 2017 at 9:46 PM, Thomas Munro wrote: > I wrote a script to cross-check various node handling functions and it told > me: > > T_NextValueExpr not handled in outfuncs.c > T_ObjectWithArgs not handled in outfuncs.c > T_AccessPriv not handled in outfuncs.c > T_CreateOpClassItem not ha

Re: [HACKERS] Inadequate infrastructure for NextValueExpr

2017-07-13 Thread Thomas Munro
On Fri, Jul 14, 2017 at 9:34 AM, Tom Lane wrote: > Somebody decided they could add a new primnode type without bothering to > build out very much infrastructure for it. Thus: > > regression=# create table foo (f1 int, f2 int generated always as identity); > CREATE TABLE > regression=# insert into

[HACKERS] Inadequate infrastructure for NextValueExpr

2017-07-13 Thread Tom Lane
Somebody decided they could add a new primnode type without bothering to build out very much infrastructure for it. Thus: regression=# create table foo (f1 int, f2 int generated always as identity); CREATE TABLE regression=# insert into foo values(1); INSERT 0 1 regression=# explain verbose inser