Re: [HACKERS] Incorrect format in error message

2016-04-01 Thread Andres Freund
On 2016-04-01 20:18:29 +1300, David Rowley wrote: > On 1 April 2016 at 17:30, Tom Lane wrote: > > David Rowley writes: > >> The attached fixes an error message which is incorrectly using an > >> unsigned format specifier instead of a signed one. > > > > Really though, what > > astonishes me about

Re: [HACKERS] Incorrect format in error message

2016-04-01 Thread David Rowley
On 1 April 2016 at 17:30, Tom Lane wrote: > David Rowley writes: >> The attached fixes an error message which is incorrectly using an >> unsigned format specifier instead of a signed one. > > Really though, what > astonishes me about this example is that we allow indexes at all on > system column

Re: [HACKERS] Incorrect format in error message

2016-04-01 Thread David Rowley
On 1 April 2016 at 17:30, Tom Lane wrote: > David Rowley writes: >> The attached fixes an error message which is incorrectly using an >> unsigned format specifier instead of a signed one. > > I think that's the tip of the iceberg :-(. For starters, the code > allows ObjectIdAttributeNumber witho

Re: [HACKERS] Incorrect format in error message

2016-03-31 Thread Tom Lane
David Rowley writes: > The attached fixes an error message which is incorrectly using an > unsigned format specifier instead of a signed one. I think that's the tip of the iceberg :-(. For starters, the code allows ObjectIdAttributeNumber without regard for the fact that the next line will dump

[HACKERS] Incorrect format in error message

2016-03-31 Thread David Rowley
The attached fixes an error message which is incorrectly using an unsigned format specifier instead of a signed one. # create table t (); # create unique index t_idx on t (ctid); # alter table t replica identity using index t_idx; ERROR: internal column 4294967295 in unique index "t_idx" I was j