On Thu, Oct 16, 2014 at 9:01 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
On Thu, Oct 16, 2014 at 7:09 PM, Simon Riggs si...@2ndquadrant.com
wrote:
I find it confusing that the Lowest pointer value is also Invalid.
Valid != Invalid
In complement to that, note that I mentioned
On 12 September 2014 13:16, Michael Paquier michael.paqu...@gmail.com wrote:
On Fri, Sep 12, 2014 at 4:55 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
I haven't looked at those places closely, but it seems possible that at
least some of those variables are supposed to be initialized
On Thu, Oct 16, 2014 at 7:09 PM, Simon Riggs si...@2ndquadrant.com wrote:
I find it confusing that the Lowest pointer value is also Invalid.
Valid != Invalid
In complement to that, note that I mentioned Invalid should be UINT_MAX for
clarity.
--
Michael
On Fri, Sep 12, 2014 at 09:16:42PM +0900, Michael Paquier wrote:
On Fri, Sep 12, 2014 at 4:55 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
I haven't looked at those places closely, but it seems possible that at
least some of those variables are supposed to be initialized to a value
On 09/12/2014 03:17 AM, Michael Paquier wrote:
On Fri, Sep 12, 2014 at 9:08 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
In walsender.c, sentPtr is initialized as follows:
static XLogRecPtr sentPtr = 0;
Isn't that incorrect and shouldn't we use InvalidXLogRecPtr instead?
Actually by
On Fri, Sep 12, 2014 at 4:55 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
I haven't looked at those places closely, but it seems possible that at
least some of those variables are supposed to be initialized to a value
smaller than any valid WAL position, rather than just Invalid. In
Hi all,
In walsender.c, sentPtr is initialized as follows:
static XLogRecPtr sentPtr = 0;
Isn't that incorrect and shouldn't we use InvalidXLogRecPtr instead?
Patch is attached.
Regards,
--
Michael
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index
On Fri, Sep 12, 2014 at 9:08 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
In walsender.c, sentPtr is initialized as follows:
static XLogRecPtr sentPtr = 0;
Isn't that incorrect and shouldn't we use InvalidXLogRecPtr instead?
Actually by looking more around I found a couple of extra
