Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-08-27 Thread Bruce Momjian
On Fri, Jan 27, 2012 at 01:45:28PM -0500, Robert Haas wrote: On Sat, Jan 7, 2012 at 12:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: I feel like this is a trick question, but I'll ask anyway: Can't we just ignore ANALYZE? AFAICS, no.  ANALYZE will run user-defined code: not only user-supplied

Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-08-27 Thread Robert Haas
On Mon, Aug 27, 2012 at 9:18 AM, Bruce Momjian br...@momjian.us wrote: Was this addressed? See commit d6d5f67b5b98b1685f9158e9d00a726afb2ae789. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-01-27 Thread Robert Haas
On Sat, Jan 7, 2012 at 12:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: I feel like this is a trick question, but I'll ask anyway: Can't we just ignore ANALYZE? AFAICS, no.  ANALYZE will run user-defined code: not only user-supplied stats collection functions, but user-defined index expressions.  

Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-01-08 Thread Simon Riggs
On Sat, Jan 7, 2012 at 5:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: BTW, if you think this is a fatal issue, then I'm afraid it's also a fatal objection to your proposal to turn SnapshotNow into an MVCC snapshot. Not just because of this, but I think its the wrong time in the cycle to be

Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-01-07 Thread Simon Riggs
On Fri, Jan 6, 2012 at 10:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Background auto-VACUUMs shouldn't cause this problem because they don't take snapshots, and ideally it'd be nice if auto-ANALYZE couldn't create the issue either, but ANALYZE does need a snapshot so it's hard to see how to

Re: [HACKERS] Intermittent regression test failures from index-only plan changes

2012-01-07 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Fri, Jan 6, 2012 at 10:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Background auto-VACUUMs shouldn't cause this problem because they don't take snapshots, and ideally it'd be nice if auto-ANALYZE couldn't create the issue either, but ANALYZE does need

[HACKERS] Intermittent regression test failures from index-only plan changes

2012-01-06 Thread Tom Lane
Another regression test failure that I've been seeing lately is a change from index-only scan to seqscan in create_index, as for instance here: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguardt=2012-01-02%2023%3A05%3A02 I've managed to duplicate and debug this one too. What I find