Re: [HACKERS] Logging configuration changes [REVIEW]

2009-09-17 Thread Peter Eisentraut
On ons, 2009-09-16 at 10:54 +0530, Abhijit Menon-Sen wrote: > I can't help but think that it would be nice to report the default value > of a parameter that is reset (i.e. "parameter $x reset to default value > $y"). The first attached patch does this by calling GetConfigOption() > after the value

Re: [HACKERS] Logging configuration changes [REVIEW]

2009-09-15 Thread Abhijit Menon-Sen
At 2009-09-16 01:18:10 -0500, jcasa...@systemguards.com.ec wrote: > > ok, maybe this is not the most brilliant observation but someone has > to say it... keep the same case in the word "parameter" ;) Oops, thanks. Re²vised patch attached. -- ams diff --git a/src/backend/utils/misc/guc-file.l b/sr

Re: [HACKERS] Logging configuration changes [REVIEW]

2009-09-15 Thread Jaime Casanova
On Wed, Sep 16, 2009 at 12:24 AM, Abhijit Menon-Sen wrote: > > LOG:  received SIGHUP, reloading configuration files > LOG:  parameter "log_connections" reset to default value "off" > LOG:  parameter "log_disconnections" reset to default value "off" > LOG:  Parameter "max_connections" cannot be cha

Re: [HACKERS] Logging configuration changes [REVIEW]

2009-09-15 Thread Abhijit Menon-Sen
(This is my review of the small patch Peter posted on 2009-08-29. See http://archives.postgresql.org/message-id/1251495487.18151.12.ca...@vanquo.pezone.net for the original message.) At 2009-08-29 00:38:07 +0300, pete...@gmx.net wrote: > > Found an easy solution; see attached patch. Neat. The pat

Re: [HACKERS] Logging configuration changes

2009-08-28 Thread Peter Eisentraut
On ons, 2009-08-26 at 22:13 -0400, Tom Lane wrote: > Seems to me it would be too chatty to be useful, at least for people who > set more than one or two things in postgresql.conf. Would it be that > hard to track which values actually changed? Without having looked at > the code, I'm thinking tha

Re: [HACKERS] Logging configuration changes

2009-08-26 Thread Tom Lane
Peter Eisentraut writes: > On sön, 2009-07-12 at 22:55 +0300, Peter Eisentraut wrote: >> On occasion, I would have found it useful if a SIGHUP didn't only log *that* >> it reloaded the configuration files, but also logged *what* had changed >> (postgresql.conf changes in particular, not so much

Re: [HACKERS] Logging configuration changes

2009-08-26 Thread Peter Eisentraut
On sön, 2009-07-12 at 22:55 +0300, Peter Eisentraut wrote: > On occasion, I would have found it useful if a SIGHUP didn't only log *that* > it reloaded the configuration files, but also logged *what* had changed > (postgresql.conf changes in particular, not so much interested in > pg_hba.conf).

Re: [HACKERS] Logging configuration changes

2009-07-12 Thread Robert Haas
On Sun, Jul 12, 2009 at 3:55 PM, Peter Eisentraut wrote: > On occasion, I would have found it useful if a SIGHUP didn't only log *that* > it reloaded the configuration files, but also logged *what* had changed > (postgresql.conf changes in particular, not so much interested in > pg_hba.conf).  Espe

[HACKERS] Logging configuration changes

2009-07-12 Thread Peter Eisentraut
On occasion, I would have found it useful if a SIGHUP didn't only log *that* it reloaded the configuration files, but also logged *what* had changed (postgresql.conf changes in particular, not so much interested in pg_hba.conf). Especially in light of the common mistake of forgetting to uncomm