Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Kevin Grittner
Tom Lane wrote: > I wrote: >> Kevin Grittner writes: >>> Any objections to my pushing the patch I posted Friday to draw a >>> distinction between populated and scannable, which also attempted >>> to address a couple points raised by you, or would you rather the >>> code didn't change at the momen

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Tom Lane
I wrote: > Kevin Grittner writes: >> Any objections to my pushing the patch I posted Friday to draw a >> distinction between populated and scannable, which also attempted >> to address a couple points raised by you, or would you rather the >> code didn't change at the moment? > I didn't look at i

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Tom Lane
Kevin Grittner writes: > Any objections to my pushing the patch I posted Friday to draw a > distinction between populated and scannable, which also attempted > to address a couple points raised by you, or would you rather the > code didn't change at the moment? I didn't look at it yet --- had my

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Kevin Grittner
Tom Lane wrote: > If we don't revert then what you pushed is clearly necessary, so > no objection to having done that.  I'll look at the larger > situation as soon as I get a chance. Any objections to my pushing the patch I posted Friday to draw a distinction between populated and scannable, whi

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Tom Lane
Robert Haas writes: > On Tue, Apr 9, 2013 at 10:25 AM, Tom Lane wrote: >> TBH I'd like to revert all of that anyway; it seemed to me to be >> basically gratuitous breakage of an API used by plugins. I've not >> had time to look at whether there was an actual reason for it and >> if so how we mig

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Robert Haas
On Tue, Apr 9, 2013 at 10:25 AM, Tom Lane wrote: > Robert Haas writes: >> The materialized views patch adjusted ExplainOneQuery to take an >> additional DestReceiver argument, but failed to add a matching >> argument to the definition of ExplainOneQuery_hook. This makes the >> hook unusable. Th

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Tom Lane
Robert Haas writes: > The materialized views patch adjusted ExplainOneQuery to take an > additional DestReceiver argument, but failed to add a matching > argument to the definition of ExplainOneQuery_hook. This makes the > hook unusable. The idea of this hook is that your hook function will > do

Re: [HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Kevin Grittner
Robert Haas wrote: > The materialized views patch adjusted ExplainOneQuery to take an > additional DestReceiver argument, but failed to add a matching > argument to the definition of ExplainOneQuery_hook.  This makes the > hook unusable.  The idea of this hook is that your hook function will > do

[HACKERS] MV patch broke users of ExplainOneQuery_hook

2013-04-09 Thread Robert Haas
The materialized views patch adjusted ExplainOneQuery to take an additional DestReceiver argument, but failed to add a matching argument to the definition of ExplainOneQuery_hook. This makes the hook unusable. The idea of this hook is that your hook function will do something before and/or after