Re: [HACKERS] Make better use of existing enums in plpgsql

2016-09-09 Thread Peter Eisentraut
On 9/4/16 12:26 PM, Pavel Stehule wrote: > I am sending review of this trivial patch. > > 1. No problems with patching, compiling > 2. all regress tests passed > 3. There are not any visible change, so tests, docs are not necessary > 4. Using enum instead int is generally good idea > > I will mar

Re: [HACKERS] Make better use of existing enums in plpgsql

2016-09-04 Thread Pavel Stehule
Hi 2016-08-19 16:56 GMT+02:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > plpgsql.h defines a number of enums, but most of the code passes them > around as ints. The attached patch updates structs and function > prototypes to take enum types instead. This clarifies the struct > defi

[HACKERS] Make better use of existing enums in plpgsql

2016-08-19 Thread Peter Eisentraut
plpgsql.h defines a number of enums, but most of the code passes them around as ints. The attached patch updates structs and function prototypes to take enum types instead. This clarifies the struct definitions in plpgsql.h in particular. I didn't deal with the PLPGSQL_RC_* symbols, since they a