Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Magnus Hagander
Tom Lane wrote: There was some discussion today about restoring pg_dump output as a non-superuser: http://archives.postgresql.org/pgsql-admin/2008-01/msg00128.php In 8.3 we have eliminated one of the major roadblocks to doing that, which is that we now allow non-superuser database owners to

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Kris Jurka
On Sun, 13 Jan 2008, Magnus Hagander wrote: Could we dump it when it's non-default only? That way the people that *have* set a custom comment on it will still get it restored, just a failure in this case. The majority of people who *haven't* set a comment will not have the problem at all.

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Could we dump it when it's non-default only? That way the people that *have* set a custom comment on it will still get it restored, just a failure in this case. The majority of people who *haven't* set a comment will not have the problem at all.

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: The easiest thing to do would be to drop the default comment. Then only custom comments would be dumped at all (at least for 8.3+ dbs). It's not like Standard public schema is particularly enlightening. Hmm, that's an interesting idea; although I fear

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Could we dump it when it's non-default only? That way the people that *have* set a custom comment on it will still get it restored, just a failure in this case. The majority of people who *haven't* set a comment will not have the

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Tom Lane wrote: We don't dump non-default comments on other system objects either, so I don't think it's out of line to suppress the one on schema public. The distinction then is if public is actually a system object. Yeah, it's a borderline case,

Re: [HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-13 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Tom Lane wrote: We don't dump non-default comments on other system objects either, so I don't think it's out of line to suppress the one on schema public. The distinction then is if public is actually a system object. Yeah, it's a

[HACKERS] Make pg_dump suppress COMMENT ON SCHEMA public ?

2008-01-12 Thread Tom Lane
There was some discussion today about restoring pg_dump output as a non-superuser: http://archives.postgresql.org/pgsql-admin/2008-01/msg00128.php In 8.3 we have eliminated one of the major roadblocks to doing that, which is that we now allow non-superuser database owners to create trusted