Re: [HACKERS] Materialized views WIP patch

2012-11-16 Thread Dimitri Fontaine
Jeff Davis writes: > The documentation says that a materialized view is basically a > create-table-as-select except that it remembers the query. Would you say > that there is a compelling use case for this alone, or is this a > building block for more sophisticated materialized view support (e.g.

Re: [HACKERS] Materialized views WIP patch

2012-11-15 Thread Jeff Davis
On Wed, 2012-11-14 at 21:28 -0500, Kevin Grittner wrote: > Attached is a patch that is still WIP but that I think is getting > pretty close to completion. It is not intended to be the be-all and > end-all for materialized views, but the minimum useful feature set -- > which is all that I've had tim

Re: [HACKERS] Materialized views WIP patch

2012-11-15 Thread Josh Berkus
Kevin, > Attached is a patch that is still WIP but that I think is getting > pretty close to completion. It is not intended to be the be-all and > end-all for materialized views, but the minimum useful feature set -- > which is all that I've had time to do for this release. In > particular, the vi

Re: [HACKERS] Materialized views WIP patch

2012-11-15 Thread Greg Smith
On 11/14/12 6:28 PM, Kevin Grittner wrote: - Documentation is incomplete. ... - There are no regression tests yet. Do you have any simple test cases you've been using you could attach? With epic new features like this, when things don't work it's hard to distinguish between "that just i

Re: [HACKERS] Materialized views WIP patch

2012-11-14 Thread Alvaro Herrera
Kevin Grittner wrote: Interesting stuff. > /* > + * SetRelationIsValid > + * Set the value of the relation's relisvalid field in pg_class. > + * > + * NOTE: caller must be holding an appropriate lock on the relation. > + * ShareUpdateExclusiveLock is sufficient. > + * > + * NOTE

<    1   2   3