Re: [HACKERS] My first patch! (to \df output)

2013-01-25 Thread Heikki Linnakangas
On 23.01.2013 07:31, Jon Erdman wrote: Done. Attached. Thanks, committed. On 29.12.2012 20:56, Stephen Frost wrote: > No biggie, and to get the bike-shedding started, I don't really like the > column name or the values.. :) I feel like something clearer would be > "Runs_As" with "caller" or "

Re: [HACKERS] My first patch! (to \df output)

2013-01-24 Thread Phil Sorber
On Thu, Jan 24, 2013 at 2:27 AM, Craig Ringer wrote: > On 01/24/2013 01:50 AM, Phil Sorber wrote: >> This looks good to me now. Compiles and works as described. > Ready to go? > > https://commitfest.postgresql.org/action/patch_view?id=1008 > I guess I wasn't ready to be so bold, but sure. :) I ch

Re: [HACKERS] My first patch! (to \df output)

2013-01-23 Thread Craig Ringer
On 01/24/2013 01:50 AM, Phil Sorber wrote: > This looks good to me now. Compiles and works as described. Ready to go? https://commitfest.postgresql.org/action/patch_view?id=1008 -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Servi

Re: [HACKERS] My first patch! (to \df output)

2013-01-23 Thread Phil Sorber
On Wed, Jan 23, 2013 at 12:31 AM, Jon Erdman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Done. Attached. > - -- > Jon T Erdman (aka StuckMojo) > PostgreSQL Zealot > > On 01/22/2013 11:17 PM, Phil Sorber wrote: >> On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman >> wrote: >> >>

Re: [HACKERS] My first patch! (to \df output)

2013-01-22 Thread Jon Erdman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Done. Attached. - -- Jon T Erdman (aka StuckMojo) PostgreSQL Zealot On 01/22/2013 11:17 PM, Phil Sorber wrote: > On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman > wrote: > > Updated the patch in commitfest with the doc change, and added a > comm

Re: [HACKERS] My first patch! (to \df output)

2013-01-22 Thread Phil Sorber
On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Updated the patch in commitfest with the doc change, and added a > comment to explain the whitespace change (it was to clean up the sql > indentation). I've also attached the new patch here

Re: [HACKERS] My first patch! (to \df output)

2013-01-22 Thread Jon Erdman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Updated the patch in commitfest with the doc change, and added a comment to explain the whitespace change (it was to clean up the sql indentation). I've also attached the new patch here for reference. - -- Jon T Erdman (aka StuckMojo) PostgreSQL Z

Re: [HACKERS] My first patch! (to \df output)

2013-01-19 Thread Stephen Frost
* Phil Sorber (p...@omniti.com) wrote: > Stephen, I think Jon's column name and values make a lot of sense. a'ight. I can't think of anything better. Thanks, Stephen signature.asc Description: Digital signature

Re: [HACKERS] My first patch! (to \df output)

2013-01-19 Thread Phil Sorber
On Jan 19, 2013 10:55 AM, "Jon Erdman" wrote: > > > I did realize that since I moved it to + the doc should change, but I didn't address that. I'll get on it this weekend. > > As far as the column name and displayed values go, they're taken from the CREATE FUNCTION syntax, and were recommended by

Re: [HACKERS] My first patch! (to \df output)

2013-01-19 Thread Jon Erdman
I did realize that since I moved it to + the doc should change, but I didn't address that. I'll get on it this weekend. As far as the column name and displayed values go, they're taken from the CREATE FUNCTION syntax, and were recommended by Magnus, Bruce, and Fetter, who were all sitting next

Re: [HACKERS] My first patch! (to \df output)

2013-01-18 Thread Phil Sorber
On Sat, Dec 29, 2012 at 1:56 PM, Stephen Frost wrote: > * Jon Erdman (postgre...@thewickedtribe.net) wrote: >> Oops! Here it is in the proper diff format. I didn't have my env set up >> correctly :( > > No biggie, and to get the bike-shedding started, I don't really like the > column name or the

Re: [HACKERS] My first patch! (to \df output)

2012-12-29 Thread Stephen Frost
* Jon Erdman (postgre...@thewickedtribe.net) wrote: > Oops! Here it is in the proper diff format. I didn't have my env set up > correctly :( No biggie, and to get the bike-shedding started, I don't really like the column name or the values.. :) I feel like something clearer would be "Runs_As" wi

Re: [HACKERS] My first patch! (to \df output)

2012-11-14 Thread Robert Haas
On Fri, Nov 9, 2012 at 3:22 PM, Jon Erdman wrote: > Oops! Here it is in the proper diff format. I didn't have my env set up > correctly :( Better add it here so it doesn't get lost: https://commitfest.postgresql.org/action/commitfest_view/open -- Robert Haas EnterpriseDB: http://www.enterpris

Re: [HACKERS] My first patch! (to \df output)

2012-11-09 Thread Jon Erdman
Oops! Here it is in the proper diff format. I didn't have my env set up correctly :( describe.patch Description: Binary data -- Jon T Erdman Postgresql Zealot On Nov 9, 2012, at 1:53 PM, Jon Erdman wrote: > On Oct 27, 2012, at 10:45 AM, Pavel Stehule wrote: > >> Hello >> >> 2012/10/27

Re: [HACKERS] My first patch! (to \df output)

2012-11-09 Thread Jon Erdman
On Oct 27, 2012, at 10:45 AM, Pavel Stehule wrote: > Hello > > 2012/10/27 Jon Erdman : >> >> Hello Hackers! >> >> So, currently the only way to see if a function is security definer or not >> is to directly query pg_proc. This is both irritating, and I think perhaps >> dangerous since securi

Re: [HACKERS] My first patch! (to \df output)

2012-10-27 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > This was actually kind of anti-climactic, since it only > took about 5 minutes to make the change and get it > working. Didn't really feel the way I expected it to ;) Well, we can reject your patch and start bike-shedding it for the next f

Re: [HACKERS] My first patch! (to \df output)

2012-10-27 Thread Pavel Stehule
Hello 2012/10/27 Jon Erdman : > > Hello Hackers! > > So, currently the only way to see if a function is security definer or not is > to directly query pg_proc. This is both irritating, and I think perhaps > dangerous since security definer functions can be so powerful. I thought > that rectify

[HACKERS] My first patch! (to \df output)

2012-10-27 Thread Jon Erdman
Hello Hackers! So, currently the only way to see if a function is security definer or not is to directly query pg_proc. This is both irritating, and I think perhaps dangerous since security definer functions can be so powerful. I thought that rectifying that would make an excellent first patc