Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-29 Thread Fujii Masao
Hi, Thanks for the comment! On Tue, Jul 28, 2009 at 12:27 AM, Tom Lanet...@sss.pgh.pa.us wrote: Well, actually, this description perfectly illustrates my basic complaint: the patch breaks the API abstraction provided by pqcomm.c. Callers are encouraged/forced to deal with the next layer down,

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-27 Thread Fujii Masao
Hi, On Sun, Jul 26, 2009 at 6:42 AM, Robert Haasrobertmh...@gmail.com wrote: OK, I agree, I can't see what this is for either from the code that is here.  I think I read a little more meaning into the title of the patch than was actually there.  It seems like the appropriate thing to do is

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-27 Thread Fujii Masao
Hi, On Sat, Jul 25, 2009 at 8:39 AM, Tom Lanet...@sss.pgh.pa.us wrote: Oh, another gripe: I'll bet a nickel that this doesn't work very nicely under SSL.  Bytes available on the socket doesn't necessarily equate to decrypted payload bytes being available.  Depending on how you're using

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-27 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Sat, Jul 25, 2009 at 8:39 AM, Tom Lanet...@sss.pgh.pa.us wrote: Oh, another gripe: I'll bet a nickel that this doesn't work very nicely under SSL.  Bytes available on the socket doesn't necessarily equate to decrypted payload bytes being available.  

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-25 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 24, 2009 at 7:21 PM, Tom Lanet...@sss.pgh.pa.us wrote: I think you should just submit this with the code that uses it, so we can evaluate whether the overall concept is a good one or not. This was split out from Synch Rep based on my

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-25 Thread Robert Haas
On Sat, Jul 25, 2009 at 11:41 AM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 24, 2009 at 7:21 PM, Tom Lanet...@sss.pgh.pa.us wrote: I think you should just submit this with the code that uses it, so we can evaluate whether the overall concept is a

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-24 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 22, 2009 at 2:20 AM, Robert Haasrobertmh...@gmail.com wrote: Are you planning to update this patch based on Martin's review? Sure. Attached is an updated patch. I looked at this patch. I don't see how we can consider accepting it by

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-24 Thread Tom Lane
I wrote: I am also thinking that if you do need the ability to get control back without blocking on the socket, you probably will need that for writes as well as reads; and this patch doesn't cover the write case. Oh, another gripe: I'll bet a nickel that this doesn't work very nicely under

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-24 Thread Robert Haas
On Fri, Jul 24, 2009 at 7:21 PM, Tom Lanet...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 22, 2009 at 2:20 AM, Robert Haasrobertmh...@gmail.com wrote: Are you planning to update this patch based on Martin's review? Sure. Attached is an updated patch. I looked

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-22 Thread Fujii Masao
Hi, On Wed, Jul 22, 2009 at 2:20 AM, Robert Haasrobertmh...@gmail.com wrote: Fujii Masao, Are you planning to update this patch based on Martin's review? Sure. Attached is an updated patch. On Fri, Jul 17, 2009 at 5:26 PM, Martin Pihlakmartin.pih...@gmail.com wrote: Here's my initial

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-21 Thread Robert Haas
On Fri, Jul 17, 2009 at 5:26 PM, Martin Pihlakmartin.pih...@gmail.com wrote: Fujii Masao wrote: http://archives.postgresql.org/pgsql-hackers/2009-07/msg00191.php In line with Robert's suggestion, I submit non-blocking pqcomm patch as a self-contained one. Here's my initial review of the

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-17 Thread Martin Pihlak
Fujii Masao wrote: http://archives.postgresql.org/pgsql-hackers/2009-07/msg00191.php In line with Robert's suggestion, I submit non-blocking pqcomm patch as a self-contained one. Here's my initial review of the non-blocking pqcomm patch. The patch applies cleanly and passes regression.

[HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-03 Thread Fujii Masao
Hi, http://archives.postgresql.org/pgsql-hackers/2009-07/msg00191.php In line with Robert's suggestion, I submit non-blocking pqcomm patch as a self-contained one. This patch provides support for non-blocking communication between a frontend and a backend. The upcoming synchronous replication