Re: [HACKERS] Obsolete reference to _bt_tuplecompare() within tuplesort.c

2014-10-22 Thread Heikki Linnakangas
On 10/19/2014 11:29 AM, Peter Geoghegan wrote: On Fri, Oct 10, 2014 at 12:33 AM, Peter Geoghegan p...@heroku.com wrote: Attached Have you looked at this? Committed now, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Obsolete reference to _bt_tuplecompare() within tuplesort.c

2014-10-19 Thread Peter Geoghegan
On Fri, Oct 10, 2014 at 12:33 AM, Peter Geoghegan p...@heroku.com wrote: Attached Have you looked at this? -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Obsolete reference to _bt_tuplecompare() within tuplesort.c

2014-10-10 Thread Heikki Linnakangas
On 10/10/2014 02:04 AM, Peter Geoghegan wrote: I found a reference made obsolete by commit 9e85183b, which is from way back in 2000. comparetup_index_btree() says: /* * This is similar to _bt_tuplecompare(), but we have already done the * index_getattr calls for the first column, and we need

Re: [HACKERS] Obsolete reference to _bt_tuplecompare() within tuplesort.c

2014-10-10 Thread Peter Geoghegan
On Thu, Oct 9, 2014 at 11:58 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Yeah. Want to write that into a patch? Attached. -- Peter Geoghegan diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c new file mode 100644 index 8e57505..2d15da0 ***

[HACKERS] Obsolete reference to _bt_tuplecompare() within tuplesort.c

2014-10-09 Thread Peter Geoghegan
I found a reference made obsolete by commit 9e85183b, which is from way back in 2000. comparetup_index_btree() says: /* * This is similar to _bt_tuplecompare(), but we have already done the * index_getattr calls for the first column, and we need to keep track of * whether any null fields are