Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-27 Thread Tom Lane
Michael Paquier writes: > On Fri, May 27, 2016 at 4:07 PM, Amit Kapila wrote: >> On Fri, May 27, 2016 at 3:05 AM, Tom Lane wrote: >>> 2. Armin proposes that WaitForTerminatingWorkers needs to do CloseHandle() >>> on the

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-27 Thread Michael Paquier
On Fri, May 27, 2016 at 4:07 PM, Amit Kapila wrote: > On Fri, May 27, 2016 at 3:05 AM, Tom Lane wrote: >> >> Michael Paquier writes: >> > ea274b2 has changed the way disconnection is done is is now closing >> > both the

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-27 Thread Amit Kapila
On Fri, May 27, 2016 at 3:05 AM, Tom Lane wrote: > > Michael Paquier writes: > > ea274b2 has changed the way disconnection is done is is now closing > > both the read and write pipes. So you may want to retry if things get > > better with the next

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-26 Thread Tom Lane
Michael Paquier writes: > ea274b2 has changed the way disconnection is done is is now closing > both the read and write pipes. So you may want to retry if things get > better with the next round of minor releases. Hadn't paid attention to this thread before ... It

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-25 Thread Michael Paquier
On Fri, Apr 8, 2016 at 2:24 AM, Michael Paquier wrote: > On Tue, Apr 5, 2016 at 9:28 AM, Armin Schöffmann > wrote: >> If this is not the correct place to discuss patches, I'd be glad if somebody >> can notify the tool's maintainer, to

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-04-08 Thread Michael Paquier
On Tue, Apr 5, 2016 at 9:28 AM, Armin Schöffmann wrote: > I propose the below patches to parallels.c and pg_backup_utils.c fixing > deadlocks in pg_restore (windows only) if running more than 2 parallel jobs. > This problem was reported by me earlier this year. >

[HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-04-04 Thread Armin Schöffmann
worthy hackers, I propose the below patches to parallels.c and pg_backup_utils.c fixing deadlocks in pg_restore (windows only) if running more than 2 parallel jobs. This problem was reported by me earlier this year.