Re: [HACKERS] PL/Perl Returned Array

2011-08-17 Thread Alex Hunsaker
On Wed, Aug 17, 2011 at 10:06, Andrew Dunstan wrote: > > > On 08/12/2011 09:17 PM, Alex Hunsaker wrote: > > [empty arrays returned are not handled correctly] > >> >> Anyway, the attached patch fixes it for me. That is when we don't have >> an array state, just return an empty array.  (Also adds so

Re: [HACKERS] PL/Perl Returned Array

2011-08-17 Thread David E. Wheeler
On Aug 17, 2011, at 9:06 AM, Andrew Dunstan wrote: > [empty arrays returned are not handled correctly] > >> Anyway, the attached patch fixes it for me. That is when we don't have >> an array state, just return an empty array. (Also adds some >> additional comments) > > Applied, thanks. Awesome

Re: [HACKERS] PL/Perl Returned Array

2011-08-17 Thread Andrew Dunstan
On 08/12/2011 09:17 PM, Alex Hunsaker wrote: [empty arrays returned are not handled correctly] Anyway, the attached patch fixes it for me. That is when we don't have an array state, just return an empty array. (Also adds some additional comments) Applied, thanks. cheers andrew -- Sent

Re: [HACKERS] PL/Perl Returned Array

2011-08-13 Thread Peter Eisentraut
On fre, 2011-08-12 at 20:09 -0700, Darren Duncan wrote: > David E. Wheeler wrote: > > On Aug 12, 2011, at 6:17 PM, Alex Hunsaker wrote: > >> Anyway, the attached patch fixes it for me. That is when we don't have > >> an array state, just return an empty array. (Also adds some > >> additional comme

Re: [HACKERS] PL/Perl Returned Array

2011-08-12 Thread Darren Duncan
David E. Wheeler wrote: On Aug 12, 2011, at 6:17 PM, Alex Hunsaker wrote: Anyway, the attached patch fixes it for me. That is when we don't have an array state, just return an empty array. (Also adds some additional comments) Fix confirmed, thank you! +1 to getting this committed before the

Re: [HACKERS] PL/Perl Returned Array

2011-08-12 Thread David E. Wheeler
On Aug 12, 2011, at 6:17 PM, Alex Hunsaker wrote: > Anyway, the attached patch fixes it for me. That is when we don't have > an array state, just return an empty array. (Also adds some > additional comments) Fix confirmed, thank you! +1 to getting this committed before the next beta/RC. David

Re: [HACKERS] PL/Perl Returned Array

2011-08-12 Thread Alex Hunsaker
On Fri, Aug 12, 2011 at 18:00, David E. Wheeler wrote: > Hackers, > > Given this script on 9.1beta3: > >    BEGIN; > >    CREATE EXTENSION plperl; > >    CREATE OR REPLACE FUNCTION wtf( >    ) RETURNS TEXT[] LANGUAGE plperl AS $$ return []; $$; > >    SELECT wtf() = '{}'::TEXT[]; > Why is that? I

[HACKERS] PL/Perl Returned Array

2011-08-12 Thread David E. Wheeler
Hackers, Given this script on 9.1beta3: BEGIN; CREATE EXTENSION plperl; CREATE OR REPLACE FUNCTION wtf( ) RETURNS TEXT[] LANGUAGE plperl AS $$ return []; $$; SELECT wtf() = '{}'::TEXT[]; ROLLBACK; The output is: BEGIN CREATE EXTENSION CREATE FUNCTION