Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-27 Thread Bernd Helmle
--On 26. September 2010 15:50:06 -0400 Tom Lane t...@sss.pgh.pa.us wrote: I think his question was - how do we feel about the massive catalog bloat this patch will create? It's a fair question. I can imagine designing things so that we don't create an explicit pg_constraint row for the

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-27 Thread Tom Lane
Bernd Helmle maili...@oopsware.de writes: What i can try is to record the inheritance information only in case of attinhcount 0. This would make maintenance of the pg_constraint records for NOT NULL columns a little complicater though. Another thing we should consider is that Peter's

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-26 Thread Bernd Helmle
--On 25. September 2010 19:55:02 -0300 José Arthur Benetasso Villanova jose.art...@gmail.com wrote: One thing that I take notice is when you create a simple table like this one: select count(*) from pg_constraint ; 12 rows appears in pg_constraint, 10 to the sequence. Is that ok? Not sure

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-26 Thread Robert Haas
On Sun, Sep 26, 2010 at 2:11 PM, Bernd Helmle maili...@oopsware.de wrote: --On 25. September 2010 19:55:02 -0300 José Arthur Benetasso Villanova jose.art...@gmail.com wrote: One thing that I take notice is when you create a simple table like this one: select count(*) from pg_constraint ; 12

Re: [HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-26 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I think his question was - how do we feel about the massive catalog bloat this patch will create? It's a fair question. I can imagine designing things so that we don't create an explicit pg_constraint row for the simplest case of an unnamed,

[HACKERS] Patch: Extend NOT NULL representation to pg_constraint

2010-09-25 Thread José Arthur Benetasso Villanova
Hi all. My name is Jose Arthur and I use PostgreSQL for a while, but never contributed to the main project, until now. Since nobody else take this patch to review in this commitfest, I'm going to try :-). The main problem can be found here: