Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Stephen Frost
* Greg Stark (st...@mit.edu) wrote: > On Thu, May 19, 2011 at 1:53 PM, Stephen Frost wrote: > > Quick code-only review: sortedAttrs is a horrible var name for what it > > is.  More like 'sortbyName' would make more sense, at least to me. > > Also, no regression test..? :) > > Do we have regressio

Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Greg Stark
On Thu, May 19, 2011 at 1:53 PM, Stephen Frost wrote: > Quick code-only review: sortedAttrs is a horrible var name for what it > is.  More like 'sortbyName' would make more sense, at least to me. > Also, no regression test..? :) Do we have regression tests for psql \ commands? -- greg -- Sent

Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Alvaro Herrera
Excerpts from Stephen Frost's message of jue may 19 13:49:33 -0400 2011: > * Alvaro Herrera (alvhe...@commandprompt.com) wrote: > > Excerpts from Greg Stark's message of jue may 19 12:11:29 -0400 2011: > > > Adding such a feature would be pretty trivial, attached is a patch. > > > > Interesting, b

Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Stephen Frost
* Greg Stark (st...@mit.edu) wrote: > Adding such a feature would be pretty trivial, attached is a patch. Quick code-only review: sortedAttrs is a horrible var name for what it is. More like 'sortbyName' would make more sense, at least to me. Also, no regression test..? :) The interface looks al

Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Stephen Frost
* Alvaro Herrera (alvhe...@commandprompt.com) wrote: > Excerpts from Greg Stark's message of jue may 19 12:11:29 -0400 2011: > > Adding such a feature would be pretty trivial, attached is a patch. > > Interesting, but not so trivial I think -- I mean if you're doing this I > think you should add a

Re: [HACKERS] Patch by request at pgcon

2011-05-19 Thread Alvaro Herrera
Excerpts from Greg Stark's message of jue may 19 12:11:29 -0400 2011: > A user at Pgcon made a pretty convincing case that it would sometimes > be handy to be able to see a list of columns in alphabetical order in > psql's \dt output. This is especially true when there are a very large > number of

[HACKERS] Patch by request at pgcon

2011-05-19 Thread Greg Stark
A user at Pgcon made a pretty convincing case that it would sometimes be handy to be able to see a list of columns in alphabetical order in psql's \dt output. This is especially true when there are a very large number of columns and you're looking for a specific column with name matching some patte