Re: [HACKERS] Patch: fix pg_dump for inherited defaults not-null flags

2012-02-10 Thread Robert Haas
On Thu, Feb 9, 2012 at 6:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Attached is a proposed patch to deal with the issue described here: http://archives.postgresql.org/pgsql-bugs/2012-02/msg0.php Even though we'd previously realized that comparing the text of inherited CHECK expressions is

Re: [HACKERS] Patch: fix pg_dump for inherited defaults not-null flags

2012-02-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Feb 9, 2012 at 6:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Although this is a bug fix, it's a nontrivial change in the logic and so I'm hesitant to back-patch into stable branches. Given the lack of prior complaints, maybe it would be best to

Re: [HACKERS] Patch: fix pg_dump for inherited defaults not-null flags

2012-02-10 Thread Robert Haas
On Fri, Feb 10, 2012 at 10:52 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Feb 9, 2012 at 6:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Although this is a bug fix, it's a nontrivial change in the logic and so I'm hesitant to back-patch into stable

Re: [HACKERS] Patch: fix pg_dump for inherited defaults not-null flags

2012-02-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: ... I'd lean toward back-patching. Not hearing any contrary opinions, that's what I've done. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Patch: fix pg_dump for inherited defaults not-null flags

2012-02-09 Thread Tom Lane
Attached is a proposed patch to deal with the issue described here: http://archives.postgresql.org/pgsql-bugs/2012-02/msg0.php Even though we'd previously realized that comparing the text of inherited CHECK expressions is an entirely unsafe way to detect expression equivalence (cf comments

Re: [HACKERS] Patch for pg_dump (function dumps)

2008-04-02 Thread Bruce Momjian
The author has received feedback so this has been saved for the next commit-fest: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Stephen Frost wrote: -- Start of PGP signed section. * Dany DeBontridder

Re: [HACKERS] Patch for pg_dump (function dumps)

2008-03-31 Thread Stephen Frost
* Dany DeBontridder ([EMAIL PROTECTED]) wrote: I often need in command line to get the code of function, so I make a patch for pg_dump, thanks this patch pg_dump is able to dump only one functions or all the functions. First, a couple of general comments about the patch: #1: You need to read

Re: [HACKERS] Patch for pg_dump

2007-05-16 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Dany DeBontridder wrote: I often need in command line to get the code of function, so I make a patch for pg_dump,

[HACKERS] Patch for pg_dump

2007-05-03 Thread Dany DeBontridder
I often need in command line to get the code of function, so I make a patch for pg_dump, thanks this patch pg_dump is able to dump only one functions or all the functions. The argument is --object or -B Example: ./pg_dump -Bfunction:test_it -Bfunction:dblink_open To dump the functions

Re: [HACKERS] Patch for pg_dump

2007-03-26 Thread Bruce Momjian
Patch withdrawn by author, perhaps reworked in the future. --- Dany DeBontridder wrote: Sorry I forgot the attach :-) It is not perfect so bear with me, it is my first try. Regards, D. On 3/21/07, Bruce Momjian

Re: [HACKERS] Patch for pg_dump

2007-03-22 Thread Dany DeBontridder
On 3/21/07, Tom Lane [EMAIL PROTECTED] wrote: Bruce Momjian [EMAIL PROTECTED] writes: I guess this matches this TODO item: o Allow selection of individual object(s) of all types, not just tables (...) Code-wise, the patch seems a bit of a mess too --- it will certainly not

Re: [HACKERS] Patch for pg_dump

2007-03-21 Thread Dany DeBontridder
Sorry I forgot the attach :-) It is not perfect so bear with me, it is my first try. Regards, D. On 3/21/07, Bruce Momjian [EMAIL PROTECTED] wrote: And the patch is so small, it is invisible (missing). ;-) --- Dany

Re: [HACKERS] Patch for pg_dump

2007-03-21 Thread Bruce Momjian
I guess this matches this TODO item: o Allow selection of individual object(s) of all types, not just tables Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of

Re: [HACKERS] Patch for pg_dump

2007-03-21 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: I guess this matches this TODO item: o Allow selection of individual object(s) of all types, not just tables Well, it's a subset of it, but do we want to accept a patch that's been designed with only a subset in mind? I'd like to see a

Re: [HACKERS] Patch for pg_dump

2007-03-21 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I guess this matches this TODO item: o Allow selection of individual object(s) of all types, not just tables Well, it's a subset of it, but do we want to accept a patch that's been designed with only a subset in

[HACKERS] Patch for pg_dump

2007-03-20 Thread Dany DeBontridder
Here is a (small) patch to give the ability to pg_dump to export only the functions (or only one), very useful when you often develop with psql ( postgresql.8.2.3) Usage: pg_dump -Q function_name DATABASE export function_name pg_dump -QDATABASE export all the functions

Re: [HACKERS] Patch for pg_dump

2007-03-20 Thread Tom Lane
Dany DeBontridder [EMAIL PROTECTED] writes: Usage: pg_dump -Q function_name DATABASE export function_name pg_dump -QDATABASE export all the functions What of overloading? And your switch syntax seems ambiguous anyway. btw, I see no patch here...

Re: [HACKERS] Patch for pg_dump

2007-03-20 Thread Bruce Momjian
And the patch is so small, it is invisible (missing). ;-) --- Dany DeBontridder wrote: Here is a (small) patch to give the ability to pg_dump to export only the functions (or only one), very useful when you often develop